Set max_length=2 on extra_choices items; remove custom validation logic

This commit is contained in:
Jeremy Stretch 2024-01-19 14:32:17 -05:00
parent f1322c932d
commit bb72af864b

View File

@ -172,7 +172,12 @@ class CustomFieldChoiceSetSerializer(ValidatedModelSerializer):
choices=CustomFieldChoiceSetBaseChoices, choices=CustomFieldChoiceSetBaseChoices,
required=False required=False
) )
extra_choices = serializers.ListField(child=serializers.ListField(min_length=2)) extra_choices = serializers.ListField(
child=serializers.ListField(
min_length=2,
max_length=2
)
)
class Meta: class Meta:
model = CustomFieldChoiceSet model = CustomFieldChoiceSet
@ -181,15 +186,6 @@ class CustomFieldChoiceSetSerializer(ValidatedModelSerializer):
'choices_count', 'created', 'last_updated', 'choices_count', 'created', 'last_updated',
] ]
def validate_extra_choices(self, value):
for choice in value:
if isinstance(choice, list):
if len(choice) < 2:
raise serializers.ValidationError('Each choice must have 2 elements.')
else:
raise serializers.ValidationError('Extra choice must be a list of two elements.')
return value
# #
# Custom links # Custom links