NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-08-04 06:38:16 -06:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

17558 raise validation error if removing choice from choiceset that is currently used

Browse Source
This commit is contained in:
Arthur Hanson 2024-09-24 10:23:16 -07:00
parent 983032189a
commit b59ae0fd93
1 changed files with 24 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
netbox/extras/models/customfields.py
View File

@ -823,8 +823,12 @@ class CustomFieldChoiceSet(CloningMixin, ExportTemplatesMixin, ChangeLoggedModel
raise ValidationError(_("Must define base or extra choices.")) raise ValidationError(_("Must define base or extra choices."))
# check if removing any used choices # check if removing any used choices
if self._original_extra_choices:
original_choices = new_choices = []
original_choices = [obj[1] for obj in self._original_extra_choices] original_choices = [obj[1] for obj in self._original_extra_choices]
if self.extra_choices:
new_choices = [obj[1] for obj in self.extra_choices] new_choices = [obj[1] for obj in self.extra_choices]
diff_choices = list(set(original_choices) - set(new_choices)) diff_choices = list(set(original_choices) - set(new_choices))
if diff_choices: if diff_choices:
# CustomFields using this ChoiceSet # CustomFields using this ChoiceSet