NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-19 17:59:11 -06:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Fix default permissions assignment under RemoteUserBackend

Browse Source
This commit is contained in:
Jeremy Stretch 2020-05-28 10:04:19 -04:00
parent 00ce3588d3
commit b2ba9d68c9
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
netbox/utilities/auth_backends.py
View File

@ -2,7 +2,8 @@ import logging
from django.conf import settings from django.conf import settings
from django.contrib.auth.backends import ModelBackend, RemoteUserBackend as _RemoteUserBackend from django.contrib.auth.backends import ModelBackend, RemoteUserBackend as _RemoteUserBackend
from django.contrib.auth.models import Group, Permission from django.contrib.auth.models import Group
from django.contrib.contenttypes.models import ContentType
from django.db.models import Q from django.db.models import Q
from users.models import ObjectPermission from users.models import ObjectPermission
@ -115,22 +116,27 @@ class RemoteUserBackend(_RemoteUserBackend):
user.groups.add(*group_list) user.groups.add(*group_list)
logger.debug(f"Assigned groups to remotely-authenticated user {user}: {group_list}") logger.debug(f"Assigned groups to remotely-authenticated user {user}: {group_list}")
# Assign default permissions to the user # Assign default object permissions to the user
permissions_list = [] permissions_list = []
for permission_name in settings.REMOTE_AUTH_DEFAULT_PERMISSIONS: for permission_name in settings.REMOTE_AUTH_DEFAULT_PERMISSIONS:
try: try:
app_label, codename = permission_name.split('.') app_label, codename = permission_name.split('.')
permissions_list.append( action, model_name = codename.split('_')
Permission.objects.get(content_type__app_label=app_label, codename=codename)
) kwargs = {
except (ValueError, Permission.DoesNotExist): 'model': ContentType.objects.get(app_label=app_label, model=model_name),
f'can_{action}': True
}
obj_perm = ObjectPermission(**kwargs)
obj_perm.save()
obj_perm.users.add(user)
permissions_list.append(permission_name)
except ValueError:
logging.error( logging.error(
"Invalid permission name: '{permission_name}'. Permissions must be in the form " "Invalid permission name: '{permission_name}'. Permissions must be in the form "
"<app>.<action>_<model>. (Example: dcim.add_site)" "<app>.<action>_<model>. (Example: dcim.add_site)"
) )
if permissions_list: if permissions_list:
# TODO: Create an ObjectPermission
user.user_permissions.add(*permissions_list)
logger.debug(f"Assigned permissions to remotely-authenticated user {user}: {permissions_list}") logger.debug(f"Assigned permissions to remotely-authenticated user {user}: {permissions_list}")
return user return user