Closes #3451: Add pre-/post-change snapshots to webhooks

netbox/extras/tests/test_webhooks.py

@@ -56,10 +56,10 @@ class WebhookTest(APITestCase):
         # Verify that a job was queued for the object creation webhook
         self.assertEqual(self.queue.count, 1)
         job = self.queue.jobs[0]
-        self.assertEqual(job.args[0], Webhook.objects.get(type_create=True))
-        self.assertEqual(job.args[1]['id'], response.data['id'])
-        self.assertEqual(job.args[2], 'site')
-        self.assertEqual(job.args[3], ObjectChangeActionChoices.ACTION_CREATE)
+        self.assertEqual(job.kwargs['webhook'], Webhook.objects.get(type_create=True))
+        self.assertEqual(job.kwargs['data']['id'], response.data['id'])
+        self.assertEqual(job.kwargs['model_name'], 'site')
+        self.assertEqual(job.kwargs['event'], ObjectChangeActionChoices.ACTION_CREATE)
 
     def test_enqueue_webhook_update(self):
         # Update an object via the REST API
@@ -75,10 +75,10 @@ class WebhookTest(APITestCase):
         # Verify that a job was queued for the object update webhook
         self.assertEqual(self.queue.count, 1)
         job = self.queue.jobs[0]
-        self.assertEqual(job.args[0], Webhook.objects.get(type_update=True))
-        self.assertEqual(job.args[1]['id'], site.pk)
-        self.assertEqual(job.args[2], 'site')
-        self.assertEqual(job.args[3], ObjectChangeActionChoices.ACTION_UPDATE)
+        self.assertEqual(job.kwargs['webhook'], Webhook.objects.get(type_update=True))
+        self.assertEqual(job.kwargs['data']['id'], site.pk)
+        self.assertEqual(job.kwargs['model_name'], 'site')
+        self.assertEqual(job.kwargs['event'], ObjectChangeActionChoices.ACTION_UPDATE)
 
     def test_enqueue_webhook_delete(self):
         # Delete an object via the REST API
@@ -91,10 +91,10 @@ class WebhookTest(APITestCase):
         # Verify that a job was queued for the object update webhook
         self.assertEqual(self.queue.count, 1)
         job = self.queue.jobs[0]
-        self.assertEqual(job.args[0], Webhook.objects.get(type_delete=True))
-        self.assertEqual(job.args[1]['id'], site.pk)
-        self.assertEqual(job.args[2], 'site')
-        self.assertEqual(job.args[3], ObjectChangeActionChoices.ACTION_DELETE)
+        self.assertEqual(job.kwargs['webhook'], Webhook.objects.get(type_delete=True))
+        self.assertEqual(job.kwargs['data']['id'], site.pk)
+        self.assertEqual(job.kwargs['model_name'], 'site')
+        self.assertEqual(job.kwargs['event'], ObjectChangeActionChoices.ACTION_DELETE)
 
     def test_webhooks_worker(self):
 
@@ -116,7 +116,7 @@ class WebhookTest(APITestCase):
             # Validate the outgoing request body
             body = json.loads(request.body)
             self.assertEqual(body['event'], 'created')
-            self.assertEqual(body['timestamp'], job.args[4])
+            self.assertEqual(body['timestamp'], job.kwargs['timestamp'])
             self.assertEqual(body['model'], 'site')
             self.assertEqual(body['username'], 'testuser')
             self.assertEqual(body['request_id'], str(request_id))
@@ -138,4 +138,4 @@ class WebhookTest(APITestCase):
 
         # Patch the Session object with our dummy_send() method, then process the webhook for sending
         with patch.object(Session, 'send', dummy_send) as mock_send:
-            process_webhook(*job.args)
+            process_webhook(**job.kwargs)

netbox/extras/webhooks.py

@@ -6,6 +6,7 @@ from django.utils import timezone
 from django_rq import get_queue
 
 from utilities.api import get_serializer_for_model
+from utilities.utils import serialize_object
 from .choices import *
 from .models import Webhook
 from .registry import registry
@@ -44,6 +45,7 @@ def enqueue_webhooks(instance, user, request_id, action):
     webhooks = Webhook.objects.filter(content_types=content_type, enabled=True, **{action_flag: True})
 
     if webhooks.exists():
+
         # Get the Model's API serializer class and serialize the object
         serializer_class = get_serializer_for_model(instance.__class__)
         serializer_context = {
@@ -51,16 +53,23 @@ def enqueue_webhooks(instance, user, request_id, action):
         }
         serializer = serializer_class(instance, context=serializer_context)
 
+        # Gather pre- and post-change snapshots
+        snapshots = {
+            'prechange': getattr(instance, '_prechange_snapshot', None),
+            'postchange': serialize_object(instance) if action != ObjectChangeActionChoices.ACTION_DELETE else None,
+        }
+
         # Enqueue the webhooks
         webhook_queue = get_queue('default')
         for webhook in webhooks:
             webhook_queue.enqueue(
                 "extras.webhooks_worker.process_webhook",
-                webhook,
-                serializer.data,
-                instance._meta.model_name,
-                action,
-                str(timezone.now()),
-                user.username,
-                request_id
+                webhook=webhook,
+                model_name=instance._meta.model_name,
+                event=action,
+                data=serializer.data,
+                snapshots=snapshots,
+                timestamp=str(timezone.now()),
+                username=user.username,
+                request_id=request_id
             )

netbox/extras/webhooks_worker.py

@@ -12,7 +12,7 @@ logger = logging.getLogger('netbox.webhooks_worker')
 
 
 @job('default')
-def process_webhook(webhook, data, model_name, event, timestamp, username, request_id):
+def process_webhook(webhook, model_name, event, data, snapshots, timestamp, username, request_id):
     """
     Make a POST request to the defined Webhook
     """
@@ -22,7 +22,8 @@ def process_webhook(webhook, data, model_name, event, timestamp, username, reque
         'model': model_name,
         'username': username,
         'request_id': request_id,
-        'data': data
+        'data': data,
+        'snapshots': snapshots,
     }
 
     # Build the headers for the HTTP request