From a87d76ad1738a67dc673a4a0e14f7a1472116e51 Mon Sep 17 00:00:00 2001 From: Abhimanyu Saharan Date: Sat, 20 Jan 2024 01:53:20 +0530 Subject: [PATCH] Fixes user delete when they have a bookmark (#14867) * fixes user delete when they have a bookmark #14851 * Include migration for user field --------- Co-authored-by: Jeremy Stretch --- .../0106_bookmark_user_cascade_deletion.py | 21 +++++++++++++++++++ netbox/extras/models/models.py | 2 +- 2 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 netbox/extras/migrations/0106_bookmark_user_cascade_deletion.py diff --git a/netbox/extras/migrations/0106_bookmark_user_cascade_deletion.py b/netbox/extras/migrations/0106_bookmark_user_cascade_deletion.py new file mode 100644 index 000000000..d7bef2f0b --- /dev/null +++ b/netbox/extras/migrations/0106_bookmark_user_cascade_deletion.py @@ -0,0 +1,21 @@ +# Generated by Django 4.2.9 on 2024-01-19 19:46 + +from django.conf import settings +from django.db import migrations, models +import django.db.models.deletion + + +class Migration(migrations.Migration): + + dependencies = [ + migrations.swappable_dependency(settings.AUTH_USER_MODEL), + ('extras', '0105_customfield_min_max_values'), + ] + + operations = [ + migrations.AlterField( + model_name='bookmark', + name='user', + field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to=settings.AUTH_USER_MODEL), + ), + ] diff --git a/netbox/extras/models/models.py b/netbox/extras/models/models.py index 778d7b68d..4ac36a3ac 100644 --- a/netbox/extras/models/models.py +++ b/netbox/extras/models/models.py @@ -771,7 +771,7 @@ class Bookmark(models.Model): ) user = models.ForeignKey( to=settings.AUTH_USER_MODEL, - on_delete=models.PROTECT + on_delete=models.CASCADE ) objects = RestrictedQuerySet.as_manager()