From a843765d0c938012135f1f7eac2c21819e107bbe Mon Sep 17 00:00:00 2001 From: Arthur Date: Wed, 12 Mar 2025 15:18:21 -0700 Subject: [PATCH] 17170 fixes --- netbox/tenancy/forms/bulk_edit.py | 10 +++++----- netbox/tenancy/tests/test_views.py | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/netbox/tenancy/forms/bulk_edit.py b/netbox/tenancy/forms/bulk_edit.py index 5af3f22ac..3f4ebad31 100644 --- a/netbox/tenancy/forms/bulk_edit.py +++ b/netbox/tenancy/forms/bulk_edit.py @@ -5,7 +5,7 @@ from netbox.forms import NetBoxModelBulkEditForm from tenancy.choices import ContactPriorityChoices from tenancy.models import * from utilities.forms import add_blank_choice -from utilities.forms.fields import CommentField, DynamicModelChoiceField +from utilities.forms.fields import CommentField, DynamicModelChoiceField, DynamicModelMultipleChoiceField from utilities.forms.rendering import FieldSet __all__ = ( @@ -90,8 +90,8 @@ class ContactRoleBulkEditForm(NetBoxModelBulkEditForm): class ContactBulkEditForm(NetBoxModelBulkEditForm): - group = DynamicModelChoiceField( - label=_('Group'), + groups = DynamicModelMultipleChoiceField( + label=_('Groups'), queryset=ContactGroup.objects.all(), required=False ) @@ -127,9 +127,9 @@ class ContactBulkEditForm(NetBoxModelBulkEditForm): model = Contact fieldsets = ( - FieldSet('group', 'title', 'phone', 'email', 'address', 'link', 'description'), + FieldSet('groups', 'title', 'phone', 'email', 'address', 'link', 'description'), ) - nullable_fields = ('group', 'title', 'phone', 'email', 'address', 'link', 'description', 'comments') + nullable_fields = ('groups', 'title', 'phone', 'email', 'address', 'link', 'description', 'comments') class ContactAssignmentBulkEditForm(NetBoxModelBulkEditForm): diff --git a/netbox/tenancy/tests/test_views.py b/netbox/tenancy/tests/test_views.py index 8c23ce150..141d850f5 100644 --- a/netbox/tenancy/tests/test_views.py +++ b/netbox/tenancy/tests/test_views.py @@ -208,13 +208,13 @@ class ContactTestCase(ViewTestCases.PrimaryObjectViewTestCase): cls.form_data = { 'name': 'Contact X', - 'group': contact_groups[1].pk, + 'groups': [contact_groups[1].pk], 'comments': 'Some comments', 'tags': [t.pk for t in tags], } cls.csv_data = ( - "group,name", + "groups,name", "Contact Group 1,Contact 4", "Contact Group 1,Contact 5", "Contact Group 1,Contact 6", @@ -228,7 +228,7 @@ class ContactTestCase(ViewTestCases.PrimaryObjectViewTestCase): ) cls.bulk_edit_data = { - 'group': contact_groups[1].pk, + 'description': "New description", }