From a69fa65669910b232dffa20dbcac46952d0c63b8 Mon Sep 17 00:00:00 2001 From: Jeremy Stretch Date: Tue, 3 Sep 2024 09:17:31 -0400 Subject: [PATCH] Disable hyperlink for invalid view names --- netbox/extras/dashboard/widgets.py | 6 +++--- netbox/templates/extras/dashboard/widgets/objectcounts.html | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/netbox/extras/dashboard/widgets.py b/netbox/extras/dashboard/widgets.py index f168df83a..d23919d9e 100644 --- a/netbox/extras/dashboard/widgets.py +++ b/netbox/extras/dashboard/widgets.py @@ -185,11 +185,11 @@ class ObjectCountsWidget(DashboardWidget): if request.user.has_perm(permission): try: url = reverse(get_viewname(model, 'list')) - except Exception: - url = '#' + except NoReverseMatch: + url = None qs = model.objects.restrict(request.user, 'view') # Apply any specified filters - if filters := self.config.get('filters'): + if url and (filters := self.config.get('filters')): params = dict_to_querydict(filters) filterset = getattr(resolve(url).func.view_class, 'filterset', None) qs = filterset(params, qs).qs diff --git a/netbox/templates/extras/dashboard/widgets/objectcounts.html b/netbox/templates/extras/dashboard/widgets/objectcounts.html index 6110aa4c0..70b71059f 100644 --- a/netbox/templates/extras/dashboard/widgets/objectcounts.html +++ b/netbox/templates/extras/dashboard/widgets/objectcounts.html @@ -3,7 +3,7 @@ {% if counts %}
{% for model, count, url in counts %} - +
{{ model|meta:"verbose_name_plural"|bettertitle }} {% if count is None %}