NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-08-23 07:56:44 -06:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

Fixes: #14023 - Fixes bulk disconnecting with multiple components attached to the same cable

Browse Source
This commit is contained in:
Daniel Sheppard 2023-10-12 11:33:49 -05:00
parent 4286c1cde2
commit a677429823
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
netbox/dcim/views.py
View File

@ -122,14 +122,18 @@ class BulkDisconnectView(GetReturnURLMixin, ObjectPermissionRequiredMixin, View)
if form.is_valid(): if form.is_valid():
with transaction.atomic(): with transaction.atomic():
cables = []
count = 0 count = 0
for obj in self.queryset.filter(pk__in=form.cleaned_data['pk']): for obj in self.queryset.filter(pk__in=form.cleaned_data['pk']):
if obj.cable is None: if obj.cable is None:
continue continue
obj.cable.delete() if obj.cable.pk not in cables:
cables.append(obj.cable.pk)
count += 1 count += 1
if len(cables) > 0:
Cable.objects.filter(pk__in=cables).delete()
messages.success(request, "Disconnected {} {}".format( messages.success(request, "Disconnected {} {}".format(
count, self.queryset.model._meta.verbose_name_plural count, self.queryset.model._meta.verbose_name_plural
)) ))