Refactor template blocks for bulk operation buttons

netbox/dcim/views.py

@@ -1,4 +1,5 @@
 import traceback
+from collections import defaultdict
 
 from django.contrib import messages
 from django.contrib.contenttypes.models import ContentType
@@ -45,6 +46,15 @@ CABLE_TERMINATION_TYPES = {
 
 
 class DeviceComponentsView(generic.ObjectChildrenView):
+    actions = ('add', 'import', 'export', 'bulk_edit', 'bulk_delete', 'bulk_rename', 'bulk_disconnect')
+    action_perms = defaultdict(set, **{
+        'add': {'add'},
+        'import': {'add'},
+        'bulk_edit': {'change'},
+        'bulk_delete': {'delete'},
+        'bulk_rename': {'change'},
+        'bulk_disconnect': {'change'},
+    })
     queryset = Device.objects.all()
 
     def get_children(self, request, parent):
@@ -1997,6 +2007,7 @@ class DeviceModuleBaysView(DeviceComponentsView):
     table = tables.DeviceModuleBayTable
     filterset = filtersets.ModuleBayFilterSet
     template_name = 'dcim/device/modulebays.html'
+    actions = ('add', 'import', 'export', 'bulk_edit', 'bulk_delete', 'bulk_rename')
     tab = ViewTab(
         label=_('Module Bays'),
         badge=lambda obj: obj.modulebays.count(),
@@ -2012,6 +2023,7 @@ class DeviceDeviceBaysView(DeviceComponentsView):
     table = tables.DeviceDeviceBayTable
     filterset = filtersets.DeviceBayFilterSet
     template_name = 'dcim/device/devicebays.html'
+    actions = ('add', 'import', 'export', 'bulk_edit', 'bulk_delete', 'bulk_rename')
     tab = ViewTab(
         label=_('Device Bays'),
         badge=lambda obj: obj.devicebays.count(),
@@ -2023,6 +2035,7 @@ class DeviceDeviceBaysView(DeviceComponentsView):
 
 @register_model_view(Device, 'inventory')
 class DeviceInventoryView(DeviceComponentsView):
+    actions = ('add', 'import', 'export', 'bulk_edit', 'bulk_delete', 'bulk_rename')
     child_model = InventoryItem
     table = tables.DeviceInventoryItemTable
     filterset = filtersets.InventoryItemFilterSet

netbox/templates/dcim/device/consoleports.html

@@ -1,6 +1,20 @@
 {% extends 'generic/objectchildren_list.html' %}
+{% load helpers %}
 
-{% block bulk_controls %}
+{% block bulk_delete_controls %}
+    {{ block.super }}
+    {% with bulk_disconnect_view=child_model|validated_viewname:"bulk_disconnect" %}
+        {% if 'bulk_disconnect' in actions and bulk_disconnect_view %}
+            <button type="submit" name="_disconnect"
+                    formaction="{% url bulk_disconnect_view %}?return_url={{ return_url }}"
+                    class="btn btn-outline-danger btn-sm">
+                <span class="mdi mdi-ethernet-cable-off" aria-hidden="true"></span> Disconnect
+            </button>
+        {% endif %}
+    {% endwith %}
+{% endblock bulk_delete_controls %}
+
+{% block bulk_extra_controls %}
     {{ block.super }}
     {% if perms.dcim.add_consoleport %}
         <div class="bulk-button-group">
@@ -10,4 +24,4 @@
             </a>
         </div>
     {% endif %}
-{% endblock %}
+{% endblock bulk_extra_controls %}

netbox/templates/dcim/device/consoleserverports.html

@@ -1,6 +1,20 @@
 {% extends 'generic/objectchildren_list.html' %}
+{% load helpers %}
 
-{% block bulk_controls %}
+{% block bulk_delete_controls %}
+    {{ block.super }}
+    {% with bulk_disconnect_view=child_model|validated_viewname:"bulk_disconnect" %}
+        {% if 'bulk_disconnect' in actions and bulk_disconnect_view %}
+            <button type="submit" name="_disconnect"
+                    formaction="{% url bulk_disconnect_view %}?return_url={{ return_url }}"
+                    class="btn btn-outline-danger btn-sm">
+                <span class="mdi mdi-ethernet-cable-off" aria-hidden="true"></span> Disconnect
+            </button>
+        {% endif %}
+    {% endwith %}
+{% endblock bulk_delete_controls %}
+
+{% block bulk_extra_controls %}
     {{ block.super }}
     {% if perms.dcim.add_consoleserverport %}
         <div class="bulk-button-group">
@@ -10,4 +24,4 @@
             </a>
         </div>
     {% endif %}
-{% endblock %}
+{% endblock bulk_extra_controls %}

netbox/templates/dcim/device/devicebays.html

@@ -1,6 +1,6 @@
 {% extends 'generic/objectchildren_list.html' %}
 
-{% block bulk_controls %}
+{% block bulk_extra_controls %}
     {{ block.super }}
     {% if perms.dcim.add_devicebay %}
         <div class="bulk-button-group">
@@ -10,4 +10,4 @@
             </a>
         </div>
     {% endif %}
-{% endblock %}
+{% endblock bulk_extra_controls %}

netbox/templates/dcim/device/frontports.html

@@ -1,6 +1,20 @@
 {% extends 'generic/objectchildren_list.html' %}
+{% load helpers %}
 
-{% block bulk_controls %}
+{% block bulk_delete_controls %}
+    {{ block.super }}
+    {% with bulk_disconnect_view=child_model|validated_viewname:"bulk_disconnect" %}
+        {% if 'bulk_disconnect' in actions and bulk_disconnect_view %}
+            <button type="submit" name="_disconnect"
+                    formaction="{% url bulk_disconnect_view %}?return_url={{ return_url }}"
+                    class="btn btn-outline-danger btn-sm">
+                <span class="mdi mdi-ethernet-cable-off" aria-hidden="true"></span> Disconnect
+            </button>
+        {% endif %}
+    {% endwith %}
+{% endblock bulk_delete_controls %}
+
+{% block bulk_extra_controls %}
     {{ block.super }}
     {% if perms.dcim.add_frontport %}
         <div class="bulk-button-group">
@@ -10,4 +24,4 @@
             </a>
         </div>
     {% endif %}
-{% endblock %}
+{% endblock bulk_extra_controls %}

netbox/templates/dcim/device/interfaces.html

@@ -1,6 +1,20 @@
 {% extends 'generic/objectchildren_list.html' %}
+{% load helpers %}
 
-{% block bulk_controls %}
+{% block bulk_delete_controls %}
+    {{ block.super }}
+    {% with bulk_disconnect_view=child_model|validated_viewname:"bulk_disconnect" %}
+        {% if 'bulk_disconnect' in actions and bulk_disconnect_view %}
+            <button type="submit" name="_disconnect"
+                    formaction="{% url bulk_disconnect_view %}?return_url={{ return_url }}"
+                    class="btn btn-outline-danger btn-sm">
+                <span class="mdi mdi-ethernet-cable-off" aria-hidden="true"></span> Disconnect
+            </button>
+        {% endif %}
+    {% endwith %}
+{% endblock bulk_delete_controls %}
+
+{% block bulk_extra_controls %}
     {{ block.super }}
     {% if perms.dcim.add_interface %}
         <div class="bulk-button-group">
@@ -10,4 +24,4 @@
             </a>
         </div>
     {% endif %}
-{% endblock %}
+{% endblock bulk_extra_controls %}

netbox/templates/dcim/device/inventory.html

@@ -1,6 +1,6 @@
 {% extends 'generic/objectchildren_list.html' %}
 
-{% block bulk_controls %}
+{% block bulk_extra_controls %}
     {{ block.super }}
     {% if perms.dcim.add_inventoryitem %}
         <div class="bulk-button-group">
@@ -10,4 +10,4 @@
             </a>
         </div>
     {% endif %}
-{% endblock %}
+{% endblock bulk_extra_controls %}

netbox/templates/dcim/device/modulebays.html

@@ -1,6 +1,6 @@
 {% extends 'generic/objectchildren_list.html' %}
 
-{% block bulk_controls %}
+{% block bulk_extra_controls %}
     {{ block.super }}
     {% if perms.dcim.add_modulebay %}
         <div class="bulk-button-group">
@@ -10,4 +10,4 @@
             </a>
         </div>
     {% endif %}
-{% endblock %}
+{% endblock bulk_extra_controls %}

netbox/templates/dcim/device/poweroutlets.html

@@ -1,6 +1,20 @@
 {% extends 'generic/objectchildren_list.html' %}
+{% load helpers %}
 
-{% block bulk_controls %}
+{% block bulk_delete_controls %}
+    {{ block.super }}
+    {% with bulk_disconnect_view=child_model|validated_viewname:"bulk_disconnect" %}
+        {% if 'bulk_disconnect' in actions and bulk_disconnect_view %}
+            <button type="submit" name="_disconnect"
+                    formaction="{% url bulk_disconnect_view %}?return_url={{ return_url }}"
+                    class="btn btn-outline-danger btn-sm">
+                <span class="mdi mdi-ethernet-cable-off" aria-hidden="true"></span> Disconnect
+            </button>
+        {% endif %}
+    {% endwith %}
+{% endblock bulk_delete_controls %}
+
+{% block bulk_extra_controls %}
     {{ block.super }}
     {% if perms.dcim.add_poweroutlet %}
         <div class="bulk-button-group">
@@ -10,4 +24,4 @@
             </a>
         </div>
     {% endif %}
-{% endblock %}
+{% endblock bulk_extra_controls %}

netbox/templates/dcim/device/powerports.html

@@ -1,6 +1,20 @@
 {% extends 'generic/objectchildren_list.html' %}
+{% load helpers %}
 
-{% block bulk_controls %}
+{% block bulk_delete_controls %}
+    {{ block.super }}
+    {% with bulk_disconnect_view=child_model|validated_viewname:"bulk_disconnect" %}
+        {% if 'bulk_disconnect' in actions and bulk_disconnect_view %}
+            <button type="submit" name="_disconnect"
+                    formaction="{% url bulk_disconnect_view %}?return_url={{ return_url }}"
+                    class="btn btn-outline-danger btn-sm">
+                <span class="mdi mdi-ethernet-cable-off" aria-hidden="true"></span> Disconnect
+            </button>
+        {% endif %}
+    {% endwith %}
+{% endblock bulk_delete_controls %}
+
+{% block bulk_extra_controls %}
     {{ block.super }}
     {% if perms.dcim.add_powerport %}
         <div class="bulk-button-group">
@@ -10,4 +24,4 @@
             </a>
         </div>
     {% endif %}
-{% endblock %}
+{% endblock bulk_extra_controls %}

netbox/templates/dcim/device/rearports.html

@@ -1,6 +1,20 @@
 {% extends 'generic/objectchildren_list.html' %}
+{% load helpers %}
 
-{% block bulk_controls %}
+{% block bulk_delete_controls %}
+    {{ block.super }}
+    {% with bulk_disconnect_view=child_model|validated_viewname:"bulk_disconnect" %}
+        {% if 'bulk_disconnect' in actions and bulk_disconnect_view %}
+            <button type="submit" name="_disconnect"
+                    formaction="{% url bulk_disconnect_view %}?return_url={{ return_url }}"
+                    class="btn btn-outline-danger btn-sm">
+                <span class="mdi mdi-ethernet-cable-off" aria-hidden="true"></span> Disconnect
+            </button>
+        {% endif %}
+    {% endwith %}
+{% endblock bulk_delete_controls %}
+
+{% block bulk_extra_controls %}
     {{ block.super }}
     {% if perms.dcim.add_rearport %}
         <div class="bulk-button-group">
@@ -10,4 +24,4 @@
             </a>
         </div>
     {% endif %}
-{% endblock %}
+{% endblock bulk_extra_controls %}

netbox/templates/dcim/rack/non_racked_devices.html

@@ -1,5 +1,4 @@
 {% extends 'generic/objectchildren_list.html' %}
-{% load helpers %}
 
 {% block extra_controls %}
     {% if perms.dcim.add_device %}
@@ -10,4 +9,4 @@
             </a>
         </div>
     {% endif %}
-{% endblock %}
+{% endblock extra_controls %}

netbox/templates/dcim/rack/reservations.html

@@ -1,5 +1,4 @@
 {% extends 'generic/objectchildren_list.html' %}
-{% load helpers %}
 
 {% block extra_controls %}
     {% if perms.dcim.add_rackreservation %}
@@ -10,4 +9,4 @@
             </a>
         </div>
     {% endif %}
-{% endblock %}
+{% endblock extra_controls %}

netbox/templates/generic/objectchildren_list.html

@@ -10,14 +10,14 @@
                 {% include 'htmx/table.html' %}
             </div>
         </div>
-
         <div class="noprint bulk-buttons">
             {% block bulk_controls %}
                 <div class="bulk-button-group">
-                    {% if 'bulk_edit' in actions %}
+                    <div class="btn-group" role="group">
-                        <div class="btn-group" role="group">
+                        {# Bulk edit buttons #}
+                        {% block bulk_edit_controls %}
                             {% with bulk_edit_view=child_model|validated_viewname:"bulk_edit" %}
-                                {% if bulk_edit_view %}
+                                {% if 'bulk_edit' in actions and bulk_edit_view %}
                                     <button type="submit" name="_edit"
                                             formaction="{% url bulk_edit_view %}?return_url={{ return_url }}"
                                             class="btn btn-warning btn-sm">
@@ -26,7 +26,7 @@
                                 {% endif %}
                             {% endwith %}
                             {% with bulk_rename_view=child_model|validated_viewname:"bulk_rename" %}
-                                {% if bulk_rename_view %}
+                                {% if 'bulk_rename' in actions and bulk_rename_view %}
                                     <button type="submit" name="_rename"
                                             formaction="{% url bulk_rename_view %}?return_url={{ return_url }}"
                                             class="btn btn-outline-warning btn-sm">
@@ -34,32 +34,28 @@
                                     </button>
                                 {% endif %}
                             {% endwith %}
-                        </div>
+                        {% endblock bulk_edit_controls %}
-                    {% endif %}
+                    </div>
                     <div class="btn-group" role="group">
-                        {% with bulk_delete_view=child_model|validated_viewname:"bulk_delete" %}
+                        {# Bulk delete buttons #}
-                            {% if 'bulk_delete' in actions and bulk_delete_view %}
+                        {% block bulk_delete_controls %}
-                                <button type="submit"
+                            {% with bulk_delete_view=child_model|validated_viewname:"bulk_delete" %}
-                                        formaction="{% url bulk_delete_view %}?return_url={{ return_url }}"
+                                {% if 'bulk_delete' in actions and bulk_delete_view %}
-                                        class="btn btn-danger btn-sm">
+                                    <button type="submit"
-                                    <i class="mdi mdi-trash-can-outline" aria-hidden="true"></i> Delete
+                                            formaction="{% url bulk_delete_view %}?return_url={{ return_url }}"
-                                </button>
+                                            class="btn btn-danger btn-sm">
-                            {% endif %}
+                                        <i class="mdi mdi-trash-can-outline" aria-hidden="true"></i> Delete
-                        {% endwith %}
-                        {% if 'bulk_edit' in actions %}
-                            {% with bulk_disconnect_view=child_model|validated_viewname:"bulk_disconnect" %}
-                                {% if bulk_disconnect_view %}
-                                    <button type="submit" name="_disconnect"
-                                            formaction="{% url bulk_disconnect_view %}?return_url={{ return_url }}"
-                                            class="btn btn-outline-danger btn-sm">
-                                        <span class="mdi mdi-ethernet-cable-off" aria-hidden="true"></span> Disconnect
                                     </button>
                                 {% endif %}
                             {% endwith %}
-                        {% endif %}
+                        {% endblock bulk_delete_controls %}
                     </div>
                 </div>
-            {% endblock %}
+                <div class="bulk-button-group">
+                    {# Other bulk action buttons #}
+                    {% block bulk_extra_controls %}{% endblock %}
+                </div>
+            {% endblock bulk_controls %}
         </div>
     </form>
 {% endblock content %}

netbox/templates/ipam/aggregate/prefixes.html

@@ -1,5 +1,4 @@
 {% extends 'generic/objectchildren_list.html' %}
-{% load helpers %}
 
 {% block extra_controls %}
   {% include 'ipam/inc/toggle_available.html' %}
@@ -9,4 +8,4 @@
     </a>
   {% endif %}
   {{ block.super }}
-{% endblock %}
+{% endblock extra_controls %}

netbox/templates/ipam/iprange/ip_addresses.html

@@ -1,10 +1,9 @@
 {% extends 'generic/objectchildren_list.html' %}
-{% load helpers %}
 
 {% block extra_controls %}
-  {% if perms.ipam.add_ipaddress and active_tab == 'ip-addresses' and object.first_available_ip %}
+  {% if perms.ipam.add_ipaddress and object.first_available_ip %}
     <a href="{% url 'ipam:ipaddress_add' %}?address={{ object.first_available_ip }}&vrf={{ object.vrf.pk }}&tenant_group={{ object.tenant.group.pk }}&tenant={{ object.tenant.pk }}" class="btn btn-sm btn-primary">
         <i class="mdi mdi-plus-thick" aria-hidden="true"></i> Add IP Address
     </a>
   {% endif %}
-{% endblock %}
+{% endblock extra_controls %}

netbox/templates/ipam/prefix/ip_addresses.html

@@ -1,5 +1,4 @@
 {% extends 'generic/objectchildren_list.html' %}
-{% load helpers %}
 
 {% block extra_controls %}
   {% if perms.ipam.add_ipaddress and first_available_ip %}
@@ -7,4 +6,4 @@
         <i class="mdi mdi-plus-thick" aria-hidden="true"></i> Add IP Address
     </a>
   {% endif %}
-{% endblock %}
+{% endblock extra_controls %}

netbox/templates/ipam/prefix/ip_ranges.html

@@ -1,5 +1,4 @@
 {% extends 'generic/objectchildren_list.html' %}
-{% load helpers %}
 
 {% block extra_controls %}
   {% if perms.ipam.add_iprange and first_available_ip %}
@@ -7,4 +6,4 @@
         <i class="mdi mdi-plus-thick" aria-hidden="true"></i> Add IP Range
     </a>
   {% endif %}
-{% endblock %}
+{% endblock extra_controls %}

netbox/templates/ipam/prefix/prefixes.html

@@ -1,5 +1,4 @@
 {% extends 'generic/objectchildren_list.html' %}
-{% load helpers %}
 
 {% block extra_controls %}
   {% include 'ipam/inc/toggle_available.html' %}
@@ -8,5 +7,4 @@
       <i class="mdi mdi-plus-thick" aria-hidden="true"></i> Add Prefix
     </a>
   {% endif %}
-  {{ block.super }}
+{% endblock extra_controls %}
-{% endblock %}