NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-12-09 01:49:35 -06:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity

Init storage at class level of BaseScript instead of in findsource function (#20575)

Browse Source
This commit is contained in:
bctiemann 2025-10-15 14:09:22 -04:00 committed by GitHub
parent 2ae98f0353
commit 9cb2c78e34
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
netbox/extras/scripts.py
View File

@ -329,6 +329,9 @@ class BaseScript:
# Declare the placeholder for the current request # Declare the placeholder for the current request
self.request = None self.request = None
# Initiate the storage backend (local, S3, etc) as a class attr
self.storage = storages.create_storage(storages.backends["scripts"])
# Compile test methods and initialize results skeleton # Compile test methods and initialize results skeleton
for method in dir(self): for method in dir(self):
if method.startswith('test_') and callable(getattr(self, method)): if method.startswith('test_') and callable(getattr(self, method)):
@ -394,8 +397,7 @@ class BaseScript:
return inspect.getfile(self.__class__) return inspect.getfile(self.__class__)
def findsource(self, object): def findsource(self, object):
storage = storages.create_storage(storages.backends["scripts"]) with self.storage.open(os.path.basename(self.filename), 'r') as f:
with storage.open(os.path.basename(self.filename), 'r') as f:
data = f.read() data = f.read()
# Break the source code into lines # Break the source code into lines