NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-14 09:51:22 -06:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Fixes #7865: REST API should support null values for console port speeds

Browse Source
This commit is contained in:
jeremystretch 2021-11-18 09:34:41 -05:00
parent c2d0cfdfc0
commit 9ae5865c2d
3 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/release-notes/version-3.0.md
View File

@ -20,7 +20,8 @@
* [#7851](https://github.com/netbox-community/netbox/issues/7851) - Add missing cluster name filter for virtual machines * [#7851](https://github.com/netbox-community/netbox/issues/7851) - Add missing cluster name filter for virtual machines
* [#7857](https://github.com/netbox-community/netbox/issues/7857) - Fix ordering IP addresses by assignment status * [#7857](https://github.com/netbox-community/netbox/issues/7857) - Fix ordering IP addresses by assignment status
* [#7859](https://github.com/netbox-community/netbox/issues/7859) - Fix styling of form widgets under cable connection views * [#7859](https://github.com/netbox-community/netbox/issues/7859) - Fix styling of form widgets under cable connection views
* [#7864](https://github.com/netbox-community/netbox/issues/7864) - `power_port` can be null when creating power outlets * [#7864](https://github.com/netbox-community/netbox/issues/7864) - `power_port` can be null when creating power outlets via REST API
* [#7865](https://github.com/netbox-community/netbox/issues/7865) - REST API should support null values for console port speeds
--- ---

4
netbox/dcim/api/serializers.py
View File

@ -539,7 +539,7 @@ class ConsoleServerPortSerializer(PrimaryModelSerializer, CableTerminationSerial
) )
speed = ChoiceField( speed = ChoiceField(
choices=ConsolePortSpeedChoices, choices=ConsolePortSpeedChoices,
allow_blank=True, allow_null=True,
required=False required=False
) )
cable = NestedCableSerializer(read_only=True) cable = NestedCableSerializer(read_only=True)
@ -563,7 +563,7 @@ class ConsolePortSerializer(PrimaryModelSerializer, CableTerminationSerializer,
) )
speed = ChoiceField( speed = ChoiceField(
choices=ConsolePortSpeedChoices, choices=ConsolePortSpeedChoices,
allow_blank=True, allow_null=True,
required=False required=False
) )
cable = NestedCableSerializer(read_only=True) cable = NestedCableSerializer(read_only=True)

6
netbox/dcim/tests/test_api.py
View File

@ -1042,14 +1042,17 @@ class ConsolePortTest(Mixins.ComponentTraceMixin, APIViewTestCases.APIViewTestCa
{ {
'device': device.pk, 'device': device.pk,
'name': 'Console Port 4', 'name': 'Console Port 4',
'speed': 9600,
}, },
{ {
'device': device.pk, 'device': device.pk,
'name': 'Console Port 5', 'name': 'Console Port 5',
'speed': 115200,
}, },
{ {
'device': device.pk, 'device': device.pk,
'name': 'Console Port 6', 'name': 'Console Port 6',
'speed': None,
}, },
] ]
@ -1081,14 +1084,17 @@ class ConsoleServerPortTest(Mixins.ComponentTraceMixin, APIViewTestCases.APIView
{ {
'device': device.pk, 'device': device.pk,
'name': 'Console Server Port 4', 'name': 'Console Server Port 4',
'speed': 9600,
}, },
{ {
'device': device.pk, 'device': device.pk,
'name': 'Console Server Port 5', 'name': 'Console Server Port 5',
'speed': 115200,
}, },
{ {
'device': device.pk, 'device': device.pk,
'name': 'Console Server Port 6', 'name': 'Console Server Port 6',
'speed': None,
}, },
] ]