diff --git a/netbox/dcim/forms/object_create.py b/netbox/dcim/forms/object_create.py index 59ea2a5ba..f37edee0a 100644 --- a/netbox/dcim/forms/object_create.py +++ b/netbox/dcim/forms/object_create.py @@ -52,9 +52,7 @@ class ComponentCreateForm(forms.Form): super().clean() # Validate that all replication fields generate an equal number of values - patterns = self.cleaned_data.get(self.replication_fields[0]) - - if not patterns: + if not (patterns := self.cleaned_data.get(self.replication_fields[0])): return pattern_count = len(patterns) diff --git a/netbox/utilities/forms/utils.py b/netbox/utilities/forms/utils.py index 92698aa23..4d737f163 100644 --- a/netbox/utilities/forms/utils.py +++ b/netbox/utilities/forms/utils.py @@ -60,7 +60,7 @@ def parse_alphanumeric_range(string): except ValueError: begin, end = dash_range, dash_range if begin.isdigit() and end.isdigit(): - if int(begin) > int(end): + if int(begin) >= int(end): raise forms.ValidationError(f'Range "{dash_range}" is invalid.') for n in list(range(int(begin), int(end) + 1)): @@ -75,7 +75,7 @@ def parse_alphanumeric_range(string): if not len(begin) == len(end) == 1: raise forms.ValidationError(f'Range "{dash_range}" is invalid.') - if ord(begin) > ord(end): + if ord(begin) >= ord(end): raise forms.ValidationError(f'Range "{dash_range}" is invalid.') for n in list(range(ord(begin), ord(end) + 1)):