From 9902e2c36d171c6557871979d0f8e938478bf5e0 Mon Sep 17 00:00:00 2001 From: Jeremy Stretch Date: Mon, 23 Oct 2023 16:06:15 -0400 Subject: [PATCH] Fix data source type choices during bulk edit --- netbox/core/forms/bulk_edit.py | 4 +--- netbox/core/utils.py | 5 ++++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/netbox/core/forms/bulk_edit.py b/netbox/core/forms/bulk_edit.py index 5ebb2ec87..8c7354d84 100644 --- a/netbox/core/forms/bulk_edit.py +++ b/netbox/core/forms/bulk_edit.py @@ -15,10 +15,8 @@ __all__ = ( class DataSourceBulkEditForm(NetBoxModelBulkEditForm): type = forms.ChoiceField( label=_('Type'), - # TODO: Field value should be empty on init (needs add_blank_choice()) choices=get_data_backend_choices, - required=False, - initial='' + required=False ) enabled = forms.NullBooleanField( required=False, diff --git a/netbox/core/utils.py b/netbox/core/utils.py index 7f54738d1..f27d1b5f7 100644 --- a/netbox/core/utils.py +++ b/netbox/core/utils.py @@ -8,7 +8,10 @@ __all__ = ( def get_data_backend_choices(): return [ - (name, cls.label) for name, cls in registry['data_backends'].items() + (None, '---------'), + *[ + (name, cls.label) for name, cls in registry['data_backends'].items() + ] ]