diff --git a/netbox/dcim/filters.py b/netbox/dcim/filters.py index dc09ee6da..59beb1a9c 100644 --- a/netbox/dcim/filters.py +++ b/netbox/dcim/filters.py @@ -2,7 +2,7 @@ import django_filters from django.contrib.auth.models import User from django.db.models import Q -from extras.filters import CustomFieldFilterSet, LocalConfigContextFilter, CreatedUpdatedFilterSet +from extras.filters import CustomFieldFilterSet, LocalConfigContextFilterSet, CreatedUpdatedFilterSet from tenancy.filtersets import TenancyFilterSet from tenancy.models import Tenant from utilities.constants import COLOR_CHOICES @@ -485,7 +485,7 @@ class PlatformFilterSet(NameSlugSearchFilterSet): fields = ['id', 'name', 'slug', 'napalm_driver'] -class DeviceFilterSet(LocalConfigContextFilter, TenancyFilterSet, CustomFieldFilterSet, CreatedUpdatedFilterSet): +class DeviceFilterSet(LocalConfigContextFilterSet, TenancyFilterSet, CustomFieldFilterSet, CreatedUpdatedFilterSet): id__in = NumericInFilter( field_name='id', lookup_expr='in' diff --git a/netbox/extras/api/views.py b/netbox/extras/api/views.py index 3164464f8..1a90b317d 100644 --- a/netbox/extras/api/views.py +++ b/netbox/extras/api/views.py @@ -102,7 +102,7 @@ class CustomFieldModelViewSet(ModelViewSet): class GraphViewSet(ModelViewSet): queryset = Graph.objects.all() serializer_class = serializers.GraphSerializer - filterset_class = filters.GraphFilter + filterset_class = filters.GraphFilterSet # @@ -112,7 +112,7 @@ class GraphViewSet(ModelViewSet): class ExportTemplateViewSet(ModelViewSet): queryset = ExportTemplate.objects.all() serializer_class = serializers.ExportTemplateSerializer - filterset_class = filters.ExportTemplateFilter + filterset_class = filters.ExportTemplateFilterSet # @@ -124,7 +124,7 @@ class TagViewSet(ModelViewSet): tagged_items=Count('extras_taggeditem_items', distinct=True) ) serializer_class = serializers.TagSerializer - filterset_class = filters.TagFilter + filterset_class = filters.TagFilterSet # @@ -145,7 +145,7 @@ class ConfigContextViewSet(ModelViewSet): 'regions', 'sites', 'roles', 'platforms', 'tenant_groups', 'tenants', ) serializer_class = serializers.ConfigContextSerializer - filterset_class = filters.ConfigContextFilter + filterset_class = filters.ConfigContextFilterSet # @@ -284,4 +284,4 @@ class ObjectChangeViewSet(ReadOnlyModelViewSet): """ queryset = ObjectChange.objects.prefetch_related('user') serializer_class = serializers.ObjectChangeSerializer - filterset_class = filters.ObjectChangeFilter + filterset_class = filters.ObjectChangeFilterSet diff --git a/netbox/extras/filters.py b/netbox/extras/filters.py index e672c4b50..792f8cee8 100644 --- a/netbox/extras/filters.py +++ b/netbox/extras/filters.py @@ -9,15 +9,15 @@ from .models import ConfigContext, CustomField, Graph, ExportTemplate, ObjectCha __all__ = ( - 'ConfigContextFilter', + 'ConfigContextFilterSet', 'CreatedUpdatedFilterSet', 'CustomFieldFilter', 'CustomFieldFilterSet', - 'ExportTemplateFilter', - 'GraphFilter', - 'LocalConfigContextFilter', - 'ObjectChangeFilter', - 'TagFilter', + 'ExportTemplateFilterSet', + 'GraphFilterSet', + 'LocalConfigContextFilterSet', + 'ObjectChangeFilterSet', + 'TagFilterSet', ) @@ -88,21 +88,21 @@ class CustomFieldFilterSet(django_filters.FilterSet): self.filters['cf_{}'.format(cf.name)] = CustomFieldFilter(field_name=cf.name, custom_field=cf) -class GraphFilter(django_filters.FilterSet): +class GraphFilterSet(django_filters.FilterSet): class Meta: model = Graph fields = ['type', 'name'] -class ExportTemplateFilter(django_filters.FilterSet): +class ExportTemplateFilterSet(django_filters.FilterSet): class Meta: model = ExportTemplate fields = ['content_type', 'name', 'template_language'] -class TagFilter(django_filters.FilterSet): +class TagFilterSet(django_filters.FilterSet): q = django_filters.CharFilter( method='search', label='Search', @@ -121,7 +121,7 @@ class TagFilter(django_filters.FilterSet): ) -class ConfigContextFilter(django_filters.FilterSet): +class ConfigContextFilterSet(django_filters.FilterSet): q = django_filters.CharFilter( method='search', label='Search', @@ -217,7 +217,7 @@ class ConfigContextFilter(django_filters.FilterSet): # Filter for Local Config Context Data # -class LocalConfigContextFilter(django_filters.FilterSet): +class LocalConfigContextFilterSet(django_filters.FilterSet): local_context_data = django_filters.BooleanFilter( method='_local_context_data', label='Has local config context data', @@ -227,7 +227,7 @@ class LocalConfigContextFilter(django_filters.FilterSet): return queryset.exclude(local_context_data__isnull=value) -class ObjectChangeFilter(django_filters.FilterSet): +class ObjectChangeFilterSet(django_filters.FilterSet): q = django_filters.CharFilter( method='search', label='Search', diff --git a/netbox/extras/tests/test_filters.py b/netbox/extras/tests/test_filters.py index dac495a52..f1f5f0d88 100644 --- a/netbox/extras/tests/test_filters.py +++ b/netbox/extras/tests/test_filters.py @@ -10,7 +10,7 @@ from tenancy.models import Tenant, TenantGroup class GraphTestCase(TestCase): queryset = Graph.objects.all() - filterset = GraphFilter + filterset = GraphFilterSet @classmethod def setUpTestData(cls): @@ -35,7 +35,7 @@ class GraphTestCase(TestCase): class ExportTemplateTestCase(TestCase): queryset = ExportTemplate.objects.all() - filterset = ExportTemplateFilter + filterset = ExportTemplateFilterSet @classmethod def setUpTestData(cls): @@ -64,7 +64,7 @@ class ExportTemplateTestCase(TestCase): class ConfigContextTestCase(TestCase): queryset = ConfigContext.objects.all() - filterset = ConfigContextFilter + filterset = ConfigContextFilterSet @classmethod def setUpTestData(cls): diff --git a/netbox/extras/views.py b/netbox/extras/views.py index df1f38d11..38d8f7342 100644 --- a/netbox/extras/views.py +++ b/netbox/extras/views.py @@ -31,7 +31,7 @@ class TagListView(PermissionRequiredMixin, ObjectListView): ).order_by( 'name' ) - filter = filters.TagFilter + filter = filters.TagFilterSet filter_form = forms.TagFilterForm table = TagTable template_name = 'extras/tag_list.html' @@ -108,7 +108,7 @@ class TagBulkDeleteView(PermissionRequiredMixin, BulkDeleteView): class ConfigContextListView(PermissionRequiredMixin, ObjectListView): permission_required = 'extras.view_configcontext' queryset = ConfigContext.objects.all() - filter = filters.ConfigContextFilter + filter = filters.ConfigContextFilterSet filter_form = forms.ConfigContextFilterForm table = ConfigContextTable template_name = 'extras/configcontext_list.html' @@ -141,7 +141,7 @@ class ConfigContextEditView(ConfigContextCreateView): class ConfigContextBulkEditView(PermissionRequiredMixin, BulkEditView): permission_required = 'extras.change_configcontext' queryset = ConfigContext.objects.all() - filter = filters.ConfigContextFilter + filter = filters.ConfigContextFilterSet table = ConfigContextTable form = forms.ConfigContextBulkEditForm default_return_url = 'extras:configcontext_list' @@ -187,7 +187,7 @@ class ObjectConfigContextView(View): class ObjectChangeListView(PermissionRequiredMixin, ObjectListView): permission_required = 'extras.view_objectchange' queryset = ObjectChange.objects.prefetch_related('user', 'changed_object_type') - filter = filters.ObjectChangeFilter + filter = filters.ObjectChangeFilterSet filter_form = forms.ObjectChangeFilterForm table = ObjectChangeTable template_name = 'extras/objectchange_list.html'