fixed 16852: misc accessbility problems

This commit is contained in:
Andrew Gormley 2024-07-24 21:33:57 +01:00
parent a5d7071274
commit 95c95bb012
5 changed files with 20 additions and 18 deletions

View File

@ -147,40 +147,40 @@ Blocks:
{% block footer_links %} {% block footer_links %}
{# Documentation #} {# Documentation #}
<li class="list-inline-item"> <li class="list-inline-item">
<a href="{% static 'docs/' %}" target="_blank" class="link-secondary" rel="noopener"> <a href="{% static 'docs/' %}" target="_blank" class="link-secondary" rel="noopener" aria-label="{% trans "Docs" %}">
<i title="{% trans "Docs" %}" class="mdi mdi-book-open-variant text-primary" data-bs-placement="top" data-bs-toggle="tooltip"></i> <i class="mdi mdi-book-open-variant text-primary" data-bs-placement="top" data-bs-toggle="tooltip"></i>
</a> </a>
</li> </li>
{# REST API #} {# REST API #}
<li class="list-inline-item"> <li class="list-inline-item">
<a href="{% url 'api-root' %}" target="_blank" class="link-secondary" rel="noopener"> <a href="{% url 'api-root' %}" target="_blank" class="link-secondary" rel="noopener" aria-label="{% trans "REST API" %}">
<i title="{% trans "REST API" %}" class="mdi mdi-cloud-braces text-primary" data-bs-placement="top" data-bs-toggle="tooltip"></i> <i class="mdi mdi-cloud-braces text-primary" data-bs-placement="top" data-bs-toggle="tooltip"></i>
</a> </a>
</li> </li>
{# API docs #} {# API docs #}
<li class="list-inline-item"> <li class="list-inline-item">
<a href="{% url 'api_docs' %}" target="_blank" class="link-secondary" rel="noopener"> <a href="{% url 'api_docs' %}" target="_blank" class="link-secondary" rel="noopener" aria-label="{% trans "REST API documentation" %}">
<i title="{% trans "REST API documentation" %}" class="mdi mdi-book text-primary" data-bs-placement="top" data-bs-toggle="tooltip"></i> <i class="mdi mdi-book text-primary" data-bs-placement="top" data-bs-toggle="tooltip"></i>
</a> </a>
</li> </li>
{# GraphQL API #} {# GraphQL API #}
{% if config.GRAPHQL_ENABLED %} {% if config.GRAPHQL_ENABLED %}
<li class="list-inline-item"> <li class="list-inline-item">
<a href="{% url 'graphql' %}" target="_blank" class="link-secondary" rel="noopener"> <a href="{% url 'graphql' %}" target="_blank" class="link-secondary" rel="noopener" aria-label="{% trans "GraphQL API" %}">
<i title="{% trans "GraphQL API" %}" class="mdi mdi-graphql text-primary" data-bs-placement="top" data-bs-toggle="tooltip"></i> <i class="mdi mdi-graphql text-primary" data-bs-placement="top" data-bs-toggle="tooltip"></i>
</a> </a>
</li> </li>
{% endif %} {% endif %}
{# GitHub #} {# GitHub #}
<li class="list-inline-item"> <li class="list-inline-item">
<a href="https://github.com/netbox-community/netbox" target="_blank" class="link-secondary" rel="noopener"> <a href="https://github.com/netbox-community/netbox" target="_blank" class="link-secondary" rel="noopener" aria-label="{% trans "Source Code" %}">
<i title="{% trans "Source Code" %}" class="mdi mdi-github text-primary" data-bs-placement="top" data-bs-toggle="tooltip"></i> <i class="mdi mdi-github text-primary" data-bs-placement="top" data-bs-toggle="tooltip"></i>
</a> </a>
</li> </li>
{# NetDev Slack #} {# NetDev Slack #}
<li class="list-inline-item"> <li class="list-inline-item">
<a href="https://netdev.chat" target="_blank" class="link-secondary" rel="noopener"> <a href="https://netdev.chat" target="_blank" class="link-secondary" rel="noopener" aria-label="{% trans "Community" %}">
<i title="{% trans "Community" %}" class="mdi mdi-slack text-primary" data-bs-placement="top" data-bs-toggle="tooltip"></i> <i class="mdi mdi-slack text-primary" data-bs-placement="top" data-bs-toggle="tooltip"></i>
</a> </a>
</li> </li>
{% endblock footer_links %} {% endblock footer_links %}

View File

@ -1,6 +1,6 @@
{% load i18n %} {% load i18n %}
<div style="margin-left: -30px"> <div style="margin-left: -30px">
<object data="{% url 'dcim-api:rack-elevation' pk=object.pk %}?face={{face}}&render=svg{% if extra_params %}&{{ extra_params }}{% endif %}" class="rack_elevation"></object> <object data="{% url 'dcim-api:rack-elevation' pk=object.pk %}?face={{face}}&render=svg{% if extra_params %}&{{ extra_params }}{% endif %}" class="rack_elevation" aria-label="Rack elevation"></object>
</div> </div>
<div class="text-center mt-3"> <div class="text-center mt-3">
<a class="btn btn-outline-primary" href="{% url 'dcim-api:rack-elevation' pk=object.pk %}?face={{face}}&render=svg{% if extra_params %}&{{ extra_params }}{% endif %}" hx-boost="false"> <a class="btn btn-outline-primary" href="{% url 'dcim-api:rack-elevation' pk=object.pk %}?face={{face}}&render=svg{% if extra_params %}&{{ extra_params }}{% endif %}" hx-boost="false">

View File

@ -15,6 +15,7 @@
hx-target="#htmx-modal-content" hx-target="#htmx-modal-content"
data-bs-toggle="modal" data-bs-toggle="modal"
data-bs-target="#htmx-modal" data-bs-target="#htmx-modal"
aria-label="{{ widget.title }} widget configuration"
> >
<i class="mdi mdi-cog {% if widget.color %} text-{{ widget.fg_color }} {% endif %}"></i> <i class="mdi mdi-cog {% if widget.color %} text-{{ widget.fg_color }} {% endif %}"></i>
</a> </a>
@ -28,6 +29,7 @@
hx-target="#htmx-modal-content" hx-target="#htmx-modal-content"
data-bs-toggle="modal" data-bs-toggle="modal"
data-bs-target="#htmx-modal" data-bs-target="#htmx-modal"
aria-label="Close {{ widget.title }} widget"
> >
<i class="mdi mdi-close {% if widget.color %} text-{{ widget.fg_color }} {% endif %}"></i> <i class="mdi mdi-close {% if widget.color %} text-{{ widget.fg_color }} {% endif %}"></i>
</a> </a>

View File

@ -145,7 +145,7 @@ Context:
{{ field.label }} {{ field.label }}
{% endif %} {% endif %}
{% if field.STATIC_CHOICES %} {% if field.STATIC_CHOICES %}
<a href="#" data-bs-toggle="modal" data-bs-target="#{{ name }}_choices"><i class="mdi mdi-help-circle"></i></a> <a href="#" data-bs-toggle="modal" data-bs-target="#{{ name }}_choices" aria-label="{{ name }} choices"><i class="mdi mdi-help-circle"></i></a>
<div class="modal fade" id="{{ name }}_choices" tabindex="-1" role="dialog"> <div class="modal fade" id="{{ name }}_choices" tabindex="-1" role="dialog">
<div class="modal-dialog" role="document"> <div class="modal-dialog" role="document">
<div class="modal-content"> <div class="modal-content">

View File

@ -16,10 +16,10 @@
</div> </div>
<div class="col-2 d-flex align-items-center"> <div class="col-2 d-flex align-items-center">
<div> <div>
<a class="btn btn-success btn-sm w-100 my-2" id="add_columns"> <a tabindex="0" class="btn btn-success btn-sm w-100 my-2" id="add_columns">
<i class="mdi mdi-arrow-right-bold"></i> {% trans "Add" %} <i class="mdi mdi-arrow-right-bold"></i> {% trans "Add" %}
</a> </a>
<a class="btn btn-danger btn-sm w-100 my-2" id="remove_columns"> <a tabindex="0" class="btn btn-danger btn-sm w-100 my-2" id="remove_columns">
<i class="mdi mdi-arrow-left-bold"></i> {% trans "Remove" %} <i class="mdi mdi-arrow-left-bold"></i> {% trans "Remove" %}
</a> </a>
</div> </div>
@ -27,10 +27,10 @@
<div class="col-5 text-center"> <div class="col-5 text-center">
{{ form.columns.label }} {{ form.columns.label }}
{{ form.columns }} {{ form.columns }}
<a class="btn btn-primary btn-sm mt-2" id="move-option-up" data-target="id_columns"> <a tabindex="0" class="btn btn-primary btn-sm mt-2" id="move-option-up" data-target="id_columns">
<i class="mdi mdi-arrow-up-bold"></i> {% trans "Move Up" %} <i class="mdi mdi-arrow-up-bold"></i> {% trans "Move Up" %}
</a> </a>
<a class="btn btn-primary btn-sm mt-2" id="move-option-down" data-target="id_columns"> <a tabindex="0" class="btn btn-primary btn-sm mt-2" id="move-option-down" data-target="id_columns">
<i class="mdi mdi-arrow-down-bold"></i> {% trans "Move Down" %} <i class="mdi mdi-arrow-down-bold"></i> {% trans "Move Down" %}
</a> </a>
</div> </div>