From 9219397208cd916a223cef9437b8f0047bee171d Mon Sep 17 00:00:00 2001
From: jeremystretch <jstretch@netboxlabs.com>
Date: Mon, 20 Mar 2023 13:04:05 -0400
Subject: [PATCH] #8958: Declare constants for event types

---
 netbox/extras/constants.py     | 18 ++++++++++++------
 netbox/extras/models/models.py |  5 +++--
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/netbox/extras/constants.py b/netbox/extras/constants.py
index d3ac97ae8..2fb43f260 100644
--- a/netbox/extras/constants.py
+++ b/netbox/extras/constants.py
@@ -1,14 +1,20 @@
-from django.contrib.contenttypes.models import ContentType
+# Events
+EVENT_CREATE = 'create'
+EVENT_UPDATE = 'update'
+EVENT_DELETE = 'delete'
+EVENT_JOB_START = 'job_start'
+EVENT_JOB_END = 'job_end'
+
 
 # Webhooks
 HTTP_CONTENT_TYPE_JSON = 'application/json'
 
 WEBHOOK_EVENT_TYPES = {
-    'create': 'created',
-    'update': 'updated',
-    'delete': 'deleted',
-    'job_start': 'job_started',
-    'job_end': 'job_ended',
+    EVENT_CREATE: 'created',
+    EVENT_UPDATE: 'updated',
+    EVENT_DELETE: 'deleted',
+    EVENT_JOB_START: 'job_started',
+    EVENT_JOB_END: 'job_ended',
 }
 
 # Dashboard
diff --git a/netbox/extras/models/models.py b/netbox/extras/models/models.py
index d1ca74822..48517c39d 100644
--- a/netbox/extras/models/models.py
+++ b/netbox/extras/models/models.py
@@ -5,6 +5,7 @@ from django.conf import settings
 from django.contrib import admin
 from django.contrib.auth.models import User
 from django.contrib.contenttypes.fields import GenericForeignKey
+from django.contrib.contenttypes.models import ContentType
 from django.core.cache import cache
 from django.core.validators import MinValueValidator, ValidationError
 from django.db import models
@@ -698,7 +699,7 @@ class JobResult(models.Model):
         JobResult.objects.filter(pk=self.pk).update(started=self.started, status=self.status)
 
         # Handle webhooks
-        self.trigger_webhooks(event='job_start')
+        self.trigger_webhooks(event=EVENT_JOB_START)
 
     def terminate(self, status=JobResultStatusChoices.STATUS_COMPLETED):
         """
@@ -714,7 +715,7 @@ class JobResult(models.Model):
         JobResult.objects.filter(pk=self.pk).update(status=self.status, completed=self.completed)
 
         # Handle webhooks
-        self.trigger_webhooks(event='job_end')
+        self.trigger_webhooks(event=EVENT_JOB_END)
 
     @classmethod
     def enqueue_job(cls, func, name, obj_type, user, schedule_at=None, interval=None, *args, **kwargs):