NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-22 11:38:45 -06:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity

use bulk_update and rebuild

Browse Source
This commit is contained in:
Arthur
2026-01-21 16:23:24 -08:00
parent 62b9367ae3
commit 91ab818411
1 changed files with 18 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
netbox/dcim/models/modules.py
View File

@@ -330,6 +330,7 @@ class Module(TrackingModelMixin, PrimaryModel, ConfigContextModel):
component._location = self.device.location component._location = self.device.location
component._rack = self.device.rack component._rack = self.device.rack
if not issubclass(component_model, MPTTModel):
component_model.objects.bulk_create(create_instances) component_model.objects.bulk_create(create_instances)
# Emit the post_save signal for each newly created object # Emit the post_save signal for each newly created object
for component in create_instances: for component in create_instances:
@@ -341,6 +342,10 @@ class Module(TrackingModelMixin, PrimaryModel, ConfigContextModel):
using='default', using='default',
update_fields=None update_fields=None
) )
else:
# MPTT models must be saved individually to maintain tree structure
for instance in create_instances:
instance.save()
update_fields = ['module'] update_fields = ['module']
@@ -356,8 +361,8 @@ class Module(TrackingModelMixin, PrimaryModel, ConfigContextModel):
update_fields=update_fields update_fields=update_fields
) )
# Rebuild MPTT tree if needed (bulk operations bypass model save) # Rebuild MPTT tree if needed (bulk_update bypasses model save)
if issubclass(component_model, MPTTModel) and (create_instances or update_instances): if issubclass(component_model, MPTTModel) and update_instances:
component_model.objects.rebuild() component_model.objects.rebuild()
# Interface bridges have to be set after interface instantiation # Interface bridges have to be set after interface instantiation