Avoid unnecessary queries in Cable.from_db

This commit is contained in:
Sander Steffann 2020-06-04 17:46:09 +02:00
parent edf15532d2
commit 8f9dcf5a97

View File

@ -2115,9 +2115,9 @@ class Cable(ChangeLoggedModel):
""" """
instance = super().from_db(db, field_names, values) instance = super().from_db(db, field_names, values)
instance._orig_termination_a_type = instance.termination_a_type instance._orig_termination_a_type_id = instance.termination_a_type_id
instance._orig_termination_a_id = instance.termination_a_id instance._orig_termination_a_id = instance.termination_a_id
instance._orig_termination_b_type = instance.termination_b_type instance._orig_termination_b_type_id = instance.termination_b_type_id
instance._orig_termination_b_id = instance.termination_b_id instance._orig_termination_b_id = instance.termination_b_id
return instance return instance
@ -2154,14 +2154,14 @@ class Cable(ChangeLoggedModel):
if self.pk: if self.pk:
err_msg = 'Cable termination points may not be modified. Delete and recreate the cable instead.' err_msg = 'Cable termination points may not be modified. Delete and recreate the cable instead.'
if ( if (
self.termination_a_type != self._orig_termination_a_type or self.termination_a_type_id != self._orig_termination_a_type_id or
self.termination_a_id != self._orig_termination_a_id self.termination_a_id != self._orig_termination_a_id
): ):
raise ValidationError({ raise ValidationError({
'termination_a': err_msg 'termination_a': err_msg
}) })
if ( if (
self.termination_b_type != self._orig_termination_b_type or self.termination_b_type_id != self._orig_termination_b_type_id or
self.termination_b_id != self._orig_termination_b_id self.termination_b_id != self._orig_termination_b_id
): ):
raise ValidationError({ raise ValidationError({