From 8cc06160199d12f017d63a7b91e363c88c96b7a8 Mon Sep 17 00:00:00 2001 From: Arthur Hanson Date: Wed, 4 Sep 2024 13:15:44 -0700 Subject: [PATCH] 17354 fix import with custom-field (#17368) * 17354 fix import with custom-field * 17354 change to use kwargs --- netbox/extras/models/customfields.py | 30 +++++++++++++++++----------- 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/netbox/extras/models/customfields.py b/netbox/extras/models/customfields.py index 839a6ace9..7a0a08614 100644 --- a/netbox/extras/models/customfields.py +++ b/netbox/extras/models/customfields.py @@ -525,23 +525,29 @@ class CustomField(CloningMixin, ExportTemplatesMixin, ChangeLoggedModel): elif self.type == CustomFieldTypeChoices.TYPE_OBJECT: model = self.related_object_type.model_class() field_class = CSVModelChoiceField if for_csv_import else DynamicModelChoiceField - field = field_class( - queryset=model.objects.all(), - required=required, - initial=initial, - query_params=self.related_object_filter - ) + kwargs = { + 'queryset': model.objects.all(), + 'required': required, + 'initial': initial, + } + if not for_csv_import: + kwargs['query_params'] = self.related_object_filter + + field = field_class(**kwargs) # Multiple objects elif self.type == CustomFieldTypeChoices.TYPE_MULTIOBJECT: model = self.related_object_type.model_class() field_class = CSVModelMultipleChoiceField if for_csv_import else DynamicModelMultipleChoiceField - field = field_class( - queryset=model.objects.all(), - required=required, - initial=initial, - query_params=self.related_object_filter - ) + kwargs = { + 'queryset': model.objects.all(), + 'required': required, + 'initial': initial, + } + if not for_csv_import: + kwargs['query_params'] = self.related_object_filter + + field = field_class(**kwargs) # Text else: