From 875db2e33bee9ab3ec286dd029fe37f2da416589 Mon Sep 17 00:00:00 2001 From: Arthur Date: Thu, 27 Apr 2023 08:02:41 -0700 Subject: [PATCH] 12252 code review changes --- netbox/netbox/search/backends.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/netbox/netbox/search/backends.py b/netbox/netbox/search/backends.py index 4bf3af9f9..4487b6bb8 100644 --- a/netbox/netbox/search/backends.py +++ b/netbox/netbox/search/backends.py @@ -145,12 +145,11 @@ class CachedValueSearchBackend(SearchBackend): ) # Omit any results pertaining to an object the user does not have permission to view - ret = [ - r for r in results if r.object is not None - ] - for r in ret: - r.name = str(r.object) - + ret = [] + for r in results: + if r.object is not None: + r.name = str(r.object) + ret.append(r) return ret def cache(self, instances, indexer=None, remove_existing=True):