From 87109f5539758a3d62ea8200d89641b21bb2d283 Mon Sep 17 00:00:00 2001 From: Julio Oliveira at Encora <149191228+Julio-Oliveira-Encora@users.noreply.github.com> Date: Tue, 4 Jun 2024 10:37:08 -0300 Subject: [PATCH] 16315 - Cant filter changelog by object type (no results found) (#16324) * Replaced "api=/api/extras/content-types/" with "/api/extras/object-types/" for JournalEntryFilterForm and ObjectChangeFilterForm. * Addressed PR comment. * Correct feature classifications --------- Co-authored-by: Jeremy Stretch --- netbox/extras/forms/filtersets.py | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/netbox/extras/forms/filtersets.py b/netbox/extras/forms/filtersets.py index d4235c465..e6b001f2c 100644 --- a/netbox/extras/forms/filtersets.py +++ b/netbox/extras/forms/filtersets.py @@ -464,13 +464,10 @@ class JournalEntryFilterForm(NetBoxModelFilterSetForm): required=False, label=_('User') ) - assigned_object_type_id = DynamicModelMultipleChoiceField( - queryset=ObjectType.objects.all(), + assigned_object_type_id = ContentTypeMultipleChoiceField( + queryset=ObjectType.objects.with_feature('journaling'), required=False, label=_('Object Type'), - widget=APISelectMultiple( - api_url='/api/extras/content-types/', - ) ) kind = forms.ChoiceField( label=_('Kind'), @@ -507,11 +504,8 @@ class ObjectChangeFilterForm(SavedFiltersMixin, FilterForm): required=False, label=_('User') ) - changed_object_type_id = DynamicModelMultipleChoiceField( - queryset=ObjectType.objects.all(), + changed_object_type_id = ContentTypeMultipleChoiceField( + queryset=ObjectType.objects.with_feature('change_logging'), required=False, label=_('Object Type'), - widget=APISelectMultiple( - api_url='/api/extras/content-types/', - ) )