NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-24 09:28:38 -06:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

PEP8 cleanup

Browse Source
This commit is contained in:
jeremystretch 2022-08-01 09:16:58 -04:00
parent 728ad51624
commit 84f2225f42
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
netbox/dcim/tests/test_models.py
View File

@ -194,14 +194,14 @@ class RackTestCase(TestCase):
# Validate inventory (front face) # Validate inventory (front face)
rack1_inventory_front = self.rack.get_rack_units(face=DeviceFaceChoices.FACE_FRONT) rack1_inventory_front = self.rack.get_rack_units(face=DeviceFaceChoices.FACE_FRONT)
self.assertEqual(rack1_inventory_front[-10]['device'], device1) self.assertEqual(rack1_inventory_front[-10]['device'], device1)
del(rack1_inventory_front[-10]) del rack1_inventory_front[-10]
for u in rack1_inventory_front: for u in rack1_inventory_front:
self.assertIsNone(u['device']) self.assertIsNone(u['device'])
# Validate inventory (rear face) # Validate inventory (rear face)
rack1_inventory_rear = self.rack.get_rack_units(face=DeviceFaceChoices.FACE_REAR) rack1_inventory_rear = self.rack.get_rack_units(face=DeviceFaceChoices.FACE_REAR)
self.assertEqual(rack1_inventory_rear[-10]['device'], device1) self.assertEqual(rack1_inventory_rear[-10]['device'], device1)
del(rack1_inventory_rear[-10]) del rack1_inventory_rear[-10]
for u in rack1_inventory_rear: for u in rack1_inventory_rear:
self.assertIsNone(u['device']) self.assertIsNone(u['device'])

2
netbox/extras/models/customfields.py
View File

@ -169,7 +169,7 @@ class CustomField(ExportTemplatesMixin, WebhooksMixin, ChangeLoggedModel):
model = ct.model_class() model = ct.model_class()
instances = model.objects.filter(**{f'custom_field_data__{self.name}__isnull': False}) instances = model.objects.filter(**{f'custom_field_data__{self.name}__isnull': False})
for instance in instances: for instance in instances:
del(instance.custom_field_data[self.name]) del instance.custom_field_data[self.name]
model.objects.bulk_update(instances, ['custom_field_data'], batch_size=100) model.objects.bulk_update(instances, ['custom_field_data'], batch_size=100)
def rename_object_data(self, old_name, new_name): def rename_object_data(self, old_name, new_name):

2
netbox/extras/tests/test_customfields.py
View File

@ -992,7 +992,7 @@ class CustomFieldModelTest(TestCase):
with self.assertRaises(ValidationError): with self.assertRaises(ValidationError):
site.clean() site.clean()
del(site.cf['bar']) del site.cf['bar']
site.clean() site.clean()
def test_missing_required_field(self): def test_missing_required_field(self):

2
netbox/extras/tests/test_registry.py
View File

@ -30,4 +30,4 @@ class RegistryTest(TestCase):
reg['foo'] = 123 reg['foo'] = 123
with self.assertRaises(TypeError): with self.assertRaises(TypeError):
del(reg['foo']) del reg['foo']

2
netbox/ipam/forms/models.py
View File

@ -848,7 +848,7 @@ class ServiceCreateForm(ServiceForm):
# Fields which may be populated from a ServiceTemplate are not required # Fields which may be populated from a ServiceTemplate are not required
for field in ('name', 'protocol', 'ports'): for field in ('name', 'protocol', 'ports'):
self.fields[field].required = False self.fields[field].required = False
del(self.fields[field].widget.attrs['required']) del self.fields[field].widget.attrs['required']
def clean(self): def clean(self):
if self.cleaned_data['service_template']: if self.cleaned_data['service_template']: