Flatten search registry to register by app_label.model_name

netbox/extras/management/commands/reindex.py

@@ -21,8 +21,7 @@ class Command(BaseCommand):
 
         # No models specified; pull in all registered indexers
         if not model_names:
-            for app_label, models in registry['search'].items():
+            for idx in registry['search'].values():
-                for _, idx in models.items():
                 indexers[idx.model] = idx
 
         # Return only indexers for the specified models
@@ -35,10 +34,10 @@ class Command(BaseCommand):
                         f"Invalid model: {label}. Model names must be in the format <app_label>.<model_name>."
                     )
                 try:
-                    idx = registry['search'][app_label][model_name]
+                    idx = registry['search'][f'{app_label}.{model_name}']
                     indexers[idx.model] = idx
                 except KeyError:
-                    raise CommandError(f"No indexer found for {label}")
+                    raise CommandError(f"No indexer registered for {label}")
 
         return indexers
 

netbox/extras/registry.py

@@ -29,5 +29,5 @@ registry['model_features'] = {
     feature: collections.defaultdict(set) for feature in EXTRAS_FEATURES
 }
 registry['denormalized_fields'] = collections.defaultdict(list)
-registry['search'] = collections.defaultdict(dict)
+registry['search'] = dict()
 registry['views'] = collections.defaultdict(dict)

netbox/netbox/search/__init__.py

@@ -97,22 +97,19 @@ class SearchIndex:
 
 def get_indexer(model):
     """
-    Get the search indexer class for the given model.
+    Get the SearchIndex class for the given model.
     """
-    app_label = model._meta.app_label
+    label = f'{model._meta.app_label}.{model._meta.model_name}'
-    model_name = model._meta.model_name
 
-    return registry['search'][app_label][model_name]
+    return registry['search'][label]
 
 
 def register_search(cls):
     """
-    Decorator for registering a SearchIndex with a particular model.
+    Decorator for registering a SearchIndex class.
     """
     model = cls.model
-    app_label = model._meta.app_label
+    label = f'{model._meta.app_label}.{model._meta.model_name}'
-    model_name = model._meta.model_name
+    registry['search'][label] = cls
-
-    registry['search'][app_label][model_name] = cls
 
     return cls

netbox/netbox/search/backends.py

@@ -35,11 +35,9 @@ class SearchBackend:
 
             # Organize choices by category
             categories = defaultdict(dict)
-            for app_label, models in registry['search'].items():
+            for label, idx in registry['search'].items():
-                for name, cls in models.items():
+                title = bettertitle(idx.model._meta.verbose_name)
-                    title = bettertitle(cls.model._meta.verbose_name)
+                categories[idx.get_category()][label] = title
-                    value = f'{app_label}.{name}'
-                    categories[cls.get_category()][value] = title
 
             # Compile a nested tuple of choices for form rendering
             results = (