diff --git a/netbox/templates/generic/object_list.html b/netbox/templates/generic/object_list.html index 86f8f4edd..c54c850a7 100644 --- a/netbox/templates/generic/object_list.html +++ b/netbox/templates/generic/object_list.html @@ -66,9 +66,10 @@ Context: {# Object list tab #}
- - {# Applied filters #} - {% applied_filters model filter_form request.GET %} + {% if not request.htmx %} + {# Applied filters #} + {% applied_filters model filter_form request.GET %} + {% endif %} {# Object table controls #} {% include 'inc/table_controls_htmx.html' with table_modal="ObjectTable_config" %} diff --git a/netbox/templates/htmx/table.html b/netbox/templates/htmx/table.html index af5bb5fc6..aabcc4c60 100644 --- a/netbox/templates/htmx/table.html +++ b/netbox/templates/htmx/table.html @@ -3,8 +3,10 @@ {% load buttons %} {% load render_table from django_tables2 %} -{# OOB Swaps to update various components #} -{% applied_filters model filter_form request.GET %} +{% if request.htmx %} + {# OOB Swaps to update various components #} + {% applied_filters model filter_form request.GET %} +{% endif %}
{% with preferences|get_key:"pagination.placement" as paginator_placement %} diff --git a/netbox/utilities/templatetags/form_helpers.py b/netbox/utilities/templatetags/form_helpers.py index 499edb332..4a2726cc5 100644 --- a/netbox/utilities/templatetags/form_helpers.py +++ b/netbox/utilities/templatetags/form_helpers.py @@ -134,7 +134,7 @@ def render_table_filter_field(fieldname, table, request): field = None # Does this table have a filterset form? - if table.filterset_form is not None: + if hasattr(table, 'filterset_form') and table.filterset_form is not None: # Get the filterset field field = get_filter_field(table.filterset_form, fieldname) diff --git a/netbox/utilities/templatetags/helpers.py b/netbox/utilities/templatetags/helpers.py index 3595c0666..d94ca321f 100644 --- a/netbox/utilities/templatetags/helpers.py +++ b/netbox/utilities/templatetags/helpers.py @@ -270,6 +270,8 @@ def applied_filters(context, model, form, query_params): Display the active filters for a given filter form. """ user = context['request'].user + if not form: + return form.is_valid() # Ensure cleaned_data has been set applied_filters = [] @@ -304,6 +306,7 @@ def applied_filters(context, model, form, query_params): save_link = f"{url}?object_types={object_type}¶meters={quote(parameters)}" return { + 'request': context['request'], 'applied_filters': applied_filters, 'save_link': save_link, } diff --git a/scripts/verify-bundles.sh b/scripts/verify-bundles.sh index cda24b6e4..e674de9bd 100755 --- a/scripts/verify-bundles.sh +++ b/scripts/verify-bundles.sh @@ -25,8 +25,6 @@ check_dist() { if [[ $diff != "" ]]; then local SHA=$(git rev-parse HEAD) echo "Commit '$SHA' produced different static assets than were committed" - echo $diff - echo $(git diff $DIST) exit 1 fi }