NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-25 18:08:38 -06:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Fixes #4222: Escape double quotes on encapsulated values during CSV export

Browse Source
This commit is contained in:
Jeremy Stretch 2020-02-24 13:29:00 -05:00
parent 36f8d6d259
commit 76138f3080
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/release-notes/version-2.7.md
View File

@ -7,6 +7,7 @@
## Bug Fixes ## Bug Fixes
* [#4221](https://github.com/netbox-community/netbox/issues/4221) - Fix exception when deleting a device with interface connections when an interfaces webhook is defined * [#4221](https://github.com/netbox-community/netbox/issues/4221) - Fix exception when deleting a device with interface connections when an interfaces webhook is defined
* [#4222](https://github.com/netbox-community/netbox/issues/4222) - Escape double quotes on encapsulated values during CSV export
* [#4224](https://github.com/netbox-community/netbox/issues/4224) - Fix display of rear device image if front image is not defined * [#4224](https://github.com/netbox-community/netbox/issues/4224) - Fix display of rear device image if front image is not defined
* [#4228](https://github.com/netbox-community/netbox/issues/4228) - Improve fit of device images in rack elevations * [#4228](https://github.com/netbox-community/netbox/issues/4228) - Improve fit of device images in rack elevations
* [#4230](https://github.com/netbox-community/netbox/issues/4230) - Fix rack units filtering on elevation endpoint * [#4230](https://github.com/netbox-community/netbox/issues/4230) - Fix rack units filtering on elevation endpoint

3
netbox/utilities/utils.py
View File

@ -31,8 +31,9 @@ def csv_format(data):
if not isinstance(value, str): if not isinstance(value, str):
value = '{}'.format(value) value = '{}'.format(value)
# Double-quote the value if it contains a comma # Double-quote the value if it contains a comma or line break
if ',' in value or '\n' in value: if ',' in value or '\n' in value:
value = value.replace('"', '""') # Escape double-quotes
csv.append('"{}"'.format(value)) csv.append('"{}"'.format(value))
else: else:
csv.append('{}'.format(value)) csv.append('{}'.format(value))