Fixes #12112: Do not link data source URL for local paths

This commit is contained in:
jeremystretch 2023-03-31 09:06:16 -04:00
parent cdad50e051
commit 730eb2e83b
4 changed files with 11 additions and 2 deletions

View File

@ -71,6 +71,7 @@ Two new webhook trigger events have been introduced: `job_start` and `job_end`.
### Bug Fixes (From Beta1)
* [#12109](https://github.com/netbox-community/netbox/issues/12109) - Fix migration error when replicating more than 100 job results
* [#12112](https://github.com/netbox-community/netbox/issues/12112) - Do not link data source URL for local paths
### Other Changes

View File

@ -95,6 +95,10 @@ class DataSource(JobsMixin, PrimaryModel):
def url_scheme(self):
return urlparse(self.source_url).scheme.lower()
@property
def is_local(self):
return self.type == DataSourceTypeChoices.LOCAL
@property
def ready_for_sync(self):
return self.enabled and self.status not in (

View File

@ -33,7 +33,7 @@
<table class="table table-hover attr-table">
<tr>
<th scope="row">Source</th>
<td><a href="{{ object.source.get_absolute_url }}">{{ object.source }}</a></td>
<td>{{ object.source|linkify }}</td>
</tr>
<tr>
<th scope="row">Path</th>

View File

@ -57,7 +57,11 @@
<tr>
<th scope="row">URL</th>
<td>
<a href="{{ object.source_url }}">{{ object.source_url }}</a>
{% if not object.is_local %}
<a href="{{ object.source_url }}">{{ object.source_url }}</a>
{% else %}
{{ object.source_url }}
{% endif %}
</td>
</tr>
<tr>