18423 review changes

This commit is contained in:
Arthur 2025-03-10 08:38:27 -07:00
parent 2517c27ab4
commit 6d1c84638c

View File

@ -79,7 +79,7 @@ class ManagedFile(SyncedDataMixin, models.Model):
return os.path.join(self._resolve_root_path(), self.file_path) return os.path.join(self._resolve_root_path(), self.file_path)
def _resolve_root_path(self): def _resolve_root_path(self):
storage = self.get_storage storage = self.storage
if isinstance(storage, ScriptFileSystemStorage): if isinstance(storage, ScriptFileSystemStorage):
return { return {
'scripts': settings.SCRIPTS_ROOT, 'scripts': settings.SCRIPTS_ROOT,
@ -98,7 +98,7 @@ class ManagedFile(SyncedDataMixin, models.Model):
Write the object's data to disk at the specified path Write the object's data to disk at the specified path
""" """
# Check whether file already exists # Check whether file already exists
storage = self.get_storage storage = self.storage
if storage.exists(path) and not overwrite: if storage.exists(path) and not overwrite:
raise FileExistsError() raise FileExistsError()
@ -106,7 +106,7 @@ class ManagedFile(SyncedDataMixin, models.Model):
new_file.write(self.data) new_file.write(self.data)
@cached_property @cached_property
def get_storage(self): def storage(self):
return storages.create_storage(storages.backends["scripts"]) return storages.create_storage(storages.backends["scripts"])
def clean(self): def clean(self):
@ -127,7 +127,7 @@ class ManagedFile(SyncedDataMixin, models.Model):
def delete(self, *args, **kwargs): def delete(self, *args, **kwargs):
# Delete file from disk # Delete file from disk
storage = self.get_storage storage = self.storage
try: try:
storage.delete(self.full_path) storage.delete(self.full_path)
except FileNotFoundError: except FileNotFoundError: