From 6ceceb5c58480e826627451e529544f2b85c74d0 Mon Sep 17 00:00:00 2001 From: Brian Tiemann Date: Mon, 17 Mar 2025 10:43:58 -0400 Subject: [PATCH] Remove skipsso backdoor --- docs/configuration/security.md | 2 +- netbox/account/views.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/configuration/security.md b/docs/configuration/security.md index c689e469f..282610b94 100644 --- a/docs/configuration/security.md +++ b/docs/configuration/security.md @@ -190,7 +190,7 @@ The lifetime (in seconds) of the authentication cookie issued to a NetBox user u Default: False -Option to hide the login form when only SSO authentication is in use. Appending `skipsso` as GET parameter shows the login form in case there is a problem with the SSO provider. +Option to hide the login form when only SSO authentication is in use. --- diff --git a/netbox/account/views.py b/netbox/account/views.py index e51dd8871..3a2dc6b32 100644 --- a/netbox/account/views.py +++ b/netbox/account/views.py @@ -89,7 +89,7 @@ class LoginView(View): if request.user.is_authenticated: logger = logging.getLogger('netbox.auth.login') return self.redirect_to_next(request, logger) - login_form_hidden = settings.LOGIN_FORM_HIDDEN and "skipsso" not in request.GET + login_form_hidden = settings.LOGIN_FORM_HIDDEN return render(request, self.template_name, { 'form': form,