From 6cc6650b32be163f70dec22dc869040eadbeac1b Mon Sep 17 00:00:00 2001 From: Jathn Date: Thu, 4 Sep 2025 14:08:48 +0300 Subject: [PATCH] Change max_digits and decimal_places to match Integer instead of BigInteger --- netbox/extras/forms/bulk_edit.py | 4 ++-- ...0_alter_customfield_validation_maximum_and_more.py} | 6 +++--- netbox/extras/models/customfields.py | 10 +++++----- 3 files changed, 10 insertions(+), 10 deletions(-) rename netbox/extras/migrations/{0130_update_custom_fields_numeric_bounds.py => 0130_alter_customfield_validation_maximum_and_more.py} (83%) diff --git a/netbox/extras/forms/bulk_edit.py b/netbox/extras/forms/bulk_edit.py index c854a6c81..ebadae8f4 100644 --- a/netbox/extras/forms/bulk_edit.py +++ b/netbox/extras/forms/bulk_edit.py @@ -73,11 +73,11 @@ class CustomFieldBulkEditForm(BulkEditForm): required=False, widget=BulkEditNullBooleanSelect() ) - validation_minimum = forms.IntegerField( + validation_minimum = forms.DecimalField( label=_('Minimum value'), required=False, ) - validation_maximum = forms.IntegerField( + validation_maximum = forms.DecimalField( label=_('Maximum value'), required=False, ) diff --git a/netbox/extras/migrations/0130_update_custom_fields_numeric_bounds.py b/netbox/extras/migrations/0130_alter_customfield_validation_maximum_and_more.py similarity index 83% rename from netbox/extras/migrations/0130_update_custom_fields_numeric_bounds.py rename to netbox/extras/migrations/0130_alter_customfield_validation_maximum_and_more.py index dcc225617..35f9a92a8 100644 --- a/netbox/extras/migrations/0130_update_custom_fields_numeric_bounds.py +++ b/netbox/extras/migrations/0130_alter_customfield_validation_maximum_and_more.py @@ -1,4 +1,4 @@ -# Generated by Django 5.2.4 on 2025-08-28 19:31 +# Generated by Django 5.2.4 on 2025-09-04 10:50 from django.db import migrations, models @@ -13,11 +13,11 @@ class Migration(migrations.Migration): migrations.AlterField( model_name='customfield', name='validation_maximum', - field=models.DecimalField(blank=True, decimal_places=2, max_digits=21, null=True), + field=models.DecimalField(blank=True, decimal_places=4, max_digits=16, null=True), ), migrations.AlterField( model_name='customfield', name='validation_minimum', - field=models.DecimalField(blank=True, decimal_places=2, max_digits=21, null=True), + field=models.DecimalField(blank=True, decimal_places=4, max_digits=16, null=True), ), ] diff --git a/netbox/extras/models/customfields.py b/netbox/extras/models/customfields.py index 78b30e9ab..2e8728fce 100644 --- a/netbox/extras/models/customfields.py +++ b/netbox/extras/models/customfields.py @@ -175,16 +175,16 @@ class CustomField(CloningMixin, ExportTemplatesMixin, ChangeLoggedModel): help_text=_('Fields with higher weights appear lower in a form.') ) validation_minimum = models.DecimalField( - max_digits=21, - decimal_places=2, + max_digits=16, + decimal_places=4, blank=True, null=True, verbose_name=_('minimum value'), help_text=_('Minimum allowed value (for numeric fields)') ) validation_maximum = models.DecimalField( - max_digits=21, - decimal_places=2, + max_digits=16, + decimal_places=4, blank=True, null=True, verbose_name=_('maximum value'), @@ -475,7 +475,7 @@ class CustomField(CloningMixin, ExportTemplatesMixin, ChangeLoggedModel): field = forms.DecimalField( required=required, initial=initial, - max_digits=12, + max_digits=16, decimal_places=4, min_value=self.validation_minimum, max_value=self.validation_maximum