From 64d11d32c883395e9cdf6e8c5b3daa12bb14f093 Mon Sep 17 00:00:00 2001
From: Jeremy Stretch <jeremy@netverity.dev>
Date: Tue, 16 Mar 2021 15:33:41 -0400
Subject: [PATCH] Fix conditional display journal & change log tabs

---
 netbox/templates/generic/object.html | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/netbox/templates/generic/object.html b/netbox/templates/generic/object.html
index 5e170a6a6..15cfcf779 100644
--- a/netbox/templates/generic/object.html
+++ b/netbox/templates/generic/object.html
@@ -53,16 +53,22 @@
         <a href="{{ object.get_absolute_url }}">{{ object|meta:"verbose_name"|bettertitle }}</a>
       </li>
       {% if perms.extras.view_journalentry %}
-        <li role="presentation"{% if active_tab == 'journal' %} class="active"{% endif %}>
-          {# TODO: Fix journal URL resolution hack #}
-          <a href="{{ object.get_absolute_url }}journal/">Journal</a>
-        </li>
+        {% with journal_viewname=object|viewname:'journal' %}
+          {% url journal_viewname pk=object.pk as journal_url %}
+          {% if journal_url %}
+            <li role="presentation"{% if active_tab == 'journal' %} class="active"{% endif %}>
+              <a href="{{ journal_url }}">Journal</a>
+            </li>
+          {% endif %}
+        {% endwith %}
       {% endif %}
       {% if perms.extras.view_objectchange %}
-        <li role="presentation"{% if active_tab == 'changelog' %} class="active"{% endif %}>
-          {# TODO: Fix changelog URL resolution hack #}
-          <a href="{{ object.get_absolute_url }}changelog/">Change Log</a>
-        </li>
+        {% with changelog_viewname=object|viewname:'changelog' %}
+          {% url changelog_viewname pk=object.pk as changelog_url %}
+          <li role="presentation"{% if active_tab == 'changelog' %} class="active"{% endif %}>
+            <a href="{{ changelog_url }}">Change Log</a>
+          </li>
+        {% endwith %}
       {% endif %}
     </ul>
   {% endblock %}