From 643b0eaf65b6bf0531072045103472716066ae1f Mon Sep 17 00:00:00 2001 From: Jeremy Stretch Date: Thu, 7 Jun 2018 14:22:56 -0400 Subject: [PATCH] Fixes #2127: Prevent non-conntectable interfaces from being connected --- netbox/dcim/models.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/netbox/dcim/models.py b/netbox/dcim/models.py index 450dc8a1b..39bd4ad3d 100644 --- a/netbox/dcim/models.py +++ b/netbox/dcim/models.py @@ -1536,6 +1536,18 @@ class InterfaceConnection(models.Model): raise ValidationError({ 'interface_b': "Cannot connect an interface to itself." }) + if self.interface_a.form_factor in NONCONNECTABLE_IFACE_TYPES: + raise ValidationError({ + 'interface_a': '{} is not a connectable interface type.'.format( + self.interface_a.get_form_factor_display() + ) + }) + if self.interface_b.form_factor in NONCONNECTABLE_IFACE_TYPES: + raise ValidationError({ + 'interface_b': '{} is not a connectable interface type.'.format( + self.interface_b.get_form_factor_display() + ) + }) except ObjectDoesNotExist: pass