NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-22 11:38:45 -06:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity

use bulk_update and rebuild

Browse Source
This commit is contained in:
Arthur
2026-01-21 16:14:14 -08:00
parent 0c091aa80e
commit 62b9367ae3
1 changed files with 26 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
netbox/dcim/models/modules.py
View File

@@ -330,13 +330,6 @@ class Module(TrackingModelMixin, PrimaryModel, ConfigContextModel):
component._location = self.device.location component._location = self.device.location
component._rack = self.device.rack component._rack = self.device.rack
if issubclass(component_model, MPTTModel):
# MPTT models must be saved individually to maintain tree structure
# Use delay_mptt_updates for better performance
with component_model.objects.delay_mptt_updates():
for instance in create_instances:
instance.save()
else:
component_model.objects.bulk_create(create_instances) component_model.objects.bulk_create(create_instances)
# Emit the post_save signal for each newly created object # Emit the post_save signal for each newly created object
for component in create_instances: for component in create_instances:
@@ -351,22 +344,6 @@ class Module(TrackingModelMixin, PrimaryModel, ConfigContextModel):
update_fields = ['module'] update_fields = ['module']
if issubclass(component_model, MPTTModel):
# MPTT models must be saved individually to maintain tree structure
# Use delay_mptt_updates for better performance - could do bulk_update
# but then would need to rebuild the tree after the updates.
with component_model.objects.delay_mptt_updates():
for component in update_instances:
component.save()
post_save.send(
sender=component_model,
instance=component,
created=False,
raw=False,
using='default',
update_fields=update_fields
)
else:
component_model.objects.bulk_update(update_instances, update_fields) component_model.objects.bulk_update(update_instances, update_fields)
# Emit the post_save signal for each updated object # Emit the post_save signal for each updated object
for component in update_instances: for component in update_instances:
@@ -379,5 +356,9 @@ class Module(TrackingModelMixin, PrimaryModel, ConfigContextModel):
update_fields=update_fields update_fields=update_fields
) )
# Rebuild MPTT tree if needed (bulk operations bypass model save)
if issubclass(component_model, MPTTModel) and (create_instances or update_instances):
component_model.objects.rebuild()
# Interface bridges have to be set after interface instantiation # Interface bridges have to be set after interface instantiation
update_interface_bridges(self.device, self.module_type.interfacetemplates, self) update_interface_bridges(self.device, self.module_type.interfacetemplates, self)