Fixes #21556: Restore previous value (if applicable) after clearing related dropdown

This commit is contained in:
Jeremy Stretch
2026-03-11 16:54:34 -04:00
parent d57f230f37
commit 61cef9400d
3 changed files with 19 additions and 7 deletions
File diff suppressed because one or more lines are too long
File diff suppressed because one or more lines are too long
@@ -71,7 +71,7 @@ export class DynamicTomSelect extends NetBoxTomSelect {
this.addEventListeners(); this.addEventListeners();
} }
load(value: string) { load(value: string, preserveValue?: string | string[]) {
const self = this; const self = this;
// Automatically clear any cached options. (Only options included // Automatically clear any cached options. (Only options included
@@ -107,6 +107,14 @@ export class DynamicTomSelect extends NetBoxTomSelect {
// Pass the options to the callback function // Pass the options to the callback function
.then(options => { .then(options => {
self.loadCallback(options, []); self.loadCallback(options, []);
// Restore the previous selection if it is still valid under the new filter.
if (preserveValue !== undefined) {
const values = Array.isArray(preserveValue) ? preserveValue : [preserveValue];
const validValues = values.filter(v => v !== '' && v in self.options);
if (validValues.length > 0) {
self.setValue(validValues.length === 1 ? validValues[0] : validValues, true);
}
}
}) })
.catch(() => { .catch(() => {
self.loadCallback([], []); self.loadCallback([], []);
@@ -338,6 +346,9 @@ export class DynamicTomSelect extends NetBoxTomSelect {
private handleEvent(event: Event): void { private handleEvent(event: Event): void {
const target = event.target as HTMLSelectElement; const target = event.target as HTMLSelectElement;
// Save the current selection so we can restore it after loading if it remains valid.
const previousValue = this.getValue();
// Update the element's URL after any changes to a dependency. // Update the element's URL after any changes to a dependency.
this.updateQueryParams(target.name); this.updateQueryParams(target.name);
this.updatePathValues(target.name); this.updatePathValues(target.name);
@@ -345,7 +356,8 @@ export class DynamicTomSelect extends NetBoxTomSelect {
// Clear any previous selection(s) as the parent filter has changed // Clear any previous selection(s) as the parent filter has changed
this.clear(); this.clear();
// Load new data. // Load new data, restoring the previous selection if it is still valid under the new filter.
this.load(this.lastValue); const preserve = previousValue !== '' && previousValue !== null ? previousValue : undefined;
this.load(this.lastValue, preserve);
} }
} }