From 614519db5c5c5e64e08658cedc2a1403d049acb0 Mon Sep 17 00:00:00 2001 From: Arthur Date: Tue, 17 Oct 2023 16:24:26 -0700 Subject: [PATCH] 14044 handle bulk rename if None name --- netbox/netbox/views/generic/bulk_views.py | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/netbox/netbox/views/generic/bulk_views.py b/netbox/netbox/views/generic/bulk_views.py index 676e3f5af..64a0e8d7a 100644 --- a/netbox/netbox/views/generic/bulk_views.py +++ b/netbox/netbox/views/generic/bulk_views.py @@ -689,14 +689,19 @@ class BulkRenameView(GetReturnURLMixin, BaseMultiObjectView): find = form.cleaned_data['find'] replace = form.cleaned_data['replace'] - if form.cleaned_data['use_regex']: - try: - obj.new_name = re.sub(find, replace, obj.name or '') - # Catch regex group reference errors - except re.error: - obj.new_name = obj.name + if obj.name: + if form.cleaned_data['use_regex']: + try: + obj.new_name = re.sub(find, replace, obj.name or '') + # Catch regex group reference errors + except re.error: + obj.new_name = obj.name + else: + if obj.name: + obj.new_name = obj.name.replace(find, replace) else: - obj.new_name = obj.name.replace(find, replace) + obj.new_name = obj.name + renamed_pks.append(obj.pk) return renamed_pks