Additional validation cleanup

This commit is contained in:
Jeremy Stretch
2018-02-01 15:53:59 -05:00
parent 2be7e1b4af
commit 5f7d30e4ec
4 changed files with 30 additions and 6 deletions

View File

@@ -2310,6 +2310,11 @@ class VCMemberSelectForm(BootstrapMixin, ChainedFieldsMixin, forms.Form):
)
)
def clean_device(self):
device = self.cleaned_data['device']
if device.virtual_chassis is not None:
raise forms.ValidationError("Device {} is already assigned to a virtual chassis.".format(device))
class DeviceVCMembershipForm(forms.ModelForm):
@@ -2321,6 +2326,12 @@ class DeviceVCMembershipForm(forms.ModelForm):
'vc_priority': 'Priority',
}
def __init__(self, *args, **kwargs):
super(DeviceVCMembershipForm, self).__init__(*args, **kwargs)
# Require VC position when assigning a member
self.fields['vc_position'].required = True
def clean_vc_position(self):
vc_position = self.cleaned_data['vc_position']
if Device.objects.filter(virtual_chassis=self.instance.virtual_chassis, vc_position=vc_position).exists():