Use display field for all API-backed select options

This commit is contained in:
checktheroads 2021-07-20 14:17:12 -07:00
parent 803f9b6913
commit 5e1156abe2
3 changed files with 1 additions and 24 deletions

Binary file not shown.

Binary file not shown.

View File

@ -314,7 +314,7 @@ class APISelect {
const options = [PLACEHOLDER] as Option[];
for (const result of results) {
const text = this.getDisplayName(result);
const text = result.display;
const data = {} as Record<string, string>;
const value = result.id.toString();
let style, selected, disabled;
@ -514,29 +514,6 @@ class APISelect {
return placeholder;
}
/**
* Find this element's display name.
*/
private getDisplayName(result: APIObjectBase): string {
let displayName = result.display;
const legacyDisplayProperty = this.base.getAttribute('display-field');
if (
typeof displayName === 'undefined' &&
legacyDisplayProperty !== null &&
legacyDisplayProperty in result
) {
displayName = result[legacyDisplayProperty] as string;
}
if (!displayName && typeof result.name === 'string') {
displayName = result.name;
}
return displayName;
}
/**
* Get this element's disabled options by value. The `data-query-param-exclude` attribute will
* contain a stringified JSON array of option values.