NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-09-06 06:13:36 -06:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

Adapt testing utilities to disregard "update" changelog records immediately following object creation

Browse Source
This commit is contained in:
Jeremy Stretch 2025-09-04 10:58:41 -04:00
parent d8822c8bca
commit 5d8be19b87
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
netbox/utilities/testing/api.py
View File

@ -247,9 +247,9 @@ class APIViewTestCases:
if issubclass(self.model, ChangeLoggingMixin): if issubclass(self.model, ChangeLoggingMixin):
objectchange = ObjectChange.objects.get( objectchange = ObjectChange.objects.get(
changed_object_type=ContentType.objects.get_for_model(instance), changed_object_type=ContentType.objects.get_for_model(instance),
changed_object_id=instance.pk changed_object_id=instance.pk,
action=ObjectChangeActionChoices.ACTION_CREATE,
) )
self.assertEqual(objectchange.action, ObjectChangeActionChoices.ACTION_CREATE)
self.assertEqual(objectchange.message, data['changelog_message']) self.assertEqual(objectchange.message, data['changelog_message'])
def test_bulk_create_objects(self): def test_bulk_create_objects(self):
@ -298,11 +298,11 @@ class APIViewTestCases:
] ]
objectchanges = ObjectChange.objects.filter( objectchanges = ObjectChange.objects.filter(
changed_object_type=ContentType.objects.get_for_model(self.model), changed_object_type=ContentType.objects.get_for_model(self.model),
changed_object_id__in=id_list changed_object_id__in=id_list,
action=ObjectChangeActionChoices.ACTION_CREATE,
) )
self.assertEqual(len(objectchanges), len(self.create_data)) self.assertEqual(len(objectchanges), len(self.create_data))
for oc in objectchanges: for oc in objectchanges:
self.assertEqual(oc.action, ObjectChangeActionChoices.ACTION_CREATE)
self.assertEqual(oc.message, changelog_message) self.assertEqual(oc.message, changelog_message)
class UpdateObjectViewTestCase(APITestCase): class UpdateObjectViewTestCase(APITestCase):

4
netbox/utilities/testing/views.py
View File

@ -655,11 +655,11 @@ class ViewTestCases:
self.assertIsNotNone(request_id, "Unable to determine request ID from response") self.assertIsNotNone(request_id, "Unable to determine request ID from response")
objectchanges = ObjectChange.objects.filter( objectchanges = ObjectChange.objects.filter(
changed_object_type=ContentType.objects.get_for_model(self.model), changed_object_type=ContentType.objects.get_for_model(self.model),
request_id=request_id request_id=request_id,
action=ObjectChangeActionChoices.ACTION_CREATE,
) )
self.assertEqual(len(objectchanges), len(self.csv_data) - 1) self.assertEqual(len(objectchanges), len(self.csv_data) - 1)
for oc in objectchanges: for oc in objectchanges:
self.assertEqual(oc.action, ObjectChangeActionChoices.ACTION_CREATE)
self.assertEqual(oc.message, data['changelog_message']) self.assertEqual(oc.message, data['changelog_message'])
@override_settings(EXEMPT_VIEW_PERMISSIONS=['*']) @override_settings(EXEMPT_VIEW_PERMISSIONS=['*'])