From 5b863d4593ff80a60e678ff5793d359359b86091 Mon Sep 17 00:00:00 2001 From: Jeremy Stretch Date: Mon, 15 Apr 2024 10:17:44 -0400 Subject: [PATCH] Apply suggestions from code review --- docs/configuration/security.md | 3 +-- netbox/netbox/settings.py | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/docs/configuration/security.md b/docs/configuration/security.md index 3b8120f5b..9de09ceda 100644 --- a/docs/configuration/security.md +++ b/docs/configuration/security.md @@ -203,8 +203,7 @@ If true, the `preload` directive will be included in the HTTP Strict Transport S Default: 0 -If set to a non-zero integer value, the SecurityMiddleware sets the HTTP Strict Transport Security header on all responses that do not already have it. -If the website must be accessed via HTTPS, it is recommended to set SECURE_HSTS_SECONDS. It will make the browser remember that the website must be accessed via HTTPS, blocking any HTTP request. +If set to a non-zero integer value, the SecurityMiddleware sets the HTTP Strict Transport Security (HSTS) header on all responses that do not already have it. This will instruct the browser that the website must be accessed via HTTPS, blocking any HTTP request. --- diff --git a/netbox/netbox/settings.py b/netbox/netbox/settings.py index ec698a8c0..55002aa87 100644 --- a/netbox/netbox/settings.py +++ b/netbox/netbox/settings.py @@ -182,7 +182,6 @@ TIME_ZONE = getattr(configuration, 'TIME_ZONE', 'UTC') ENABLE_LOCALIZATION = getattr(configuration, 'ENABLE_LOCALIZATION', False) CHANGELOG_SKIP_EMPTY_CHANGES = getattr(configuration, 'CHANGELOG_SKIP_EMPTY_CHANGES', True) - # Check for hard-coded dynamic config parameters for param in PARAMS: if hasattr(configuration, param.name):