NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-22 12:06:53 -06:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Adds ip to failed logs (#12725)

Browse Source 
* adds ip to failed logs #12562

* added additional logging when client ip cannot be determined
This commit is contained in:
Abhimanyu Saharan 2023-05-26 18:16:49 +05:30 committed by GitHub
parent e2f9a3c07a
commit 5869894a48
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
netbox/users/signals.py
View File

@ -1,10 +1,18 @@
import logging import logging
from django.dispatch import receiver from django.dispatch import receiver
from django.contrib.auth.signals import user_login_failed from django.contrib.auth.signals import user_login_failed
from utilities.request import get_client_ip
@receiver(user_login_failed) @receiver(user_login_failed)
def log_user_login_failed(sender, credentials, request, **kwargs): def log_user_login_failed(sender, credentials, request, **kwargs):
logger = logging.getLogger('netbox.auth.login') logger = logging.getLogger('netbox.auth.login')
username = credentials.get("username") username = credentials.get("username")
logger.info(f"Failed login attempt for username: {username}") if client_ip := get_client_ip(request):
logger.info(f"Failed login attempt for username: {username} from {client_ip}")
else:
logger.warning(
"Client IP address could not be determined for validation. Check that the HTTP server is properly "
"configured to pass the required header(s)."
)
logger.info(f"Failed login attempt for username: {username}")