Clean up user & group import

This commit is contained in:
Jeremy Stretch 2023-07-20 10:45:54 -04:00
parent 4702cc049f
commit 56cb542e1a
2 changed files with 17 additions and 10 deletions

View File

@ -368,6 +368,13 @@ ADMIN_MENU = Menu(
permissions=[f'auth.add_user'],
color=ButtonColorChoices.GREEN
),
MenuItemButton(
link=f'users:netboxuser_import',
title='Import',
icon_class='mdi mdi-upload',
permissions=[f'auth.add_user'],
color=ButtonColorChoices.CYAN
)
)
),
# Proxy model for auth.Group
@ -383,6 +390,13 @@ ADMIN_MENU = Menu(
permissions=[f'auth.add_group'],
color=ButtonColorChoices.GREEN
),
MenuItemButton(
link=f'users:netboxgroup_import',
title='Import',
icon_class='mdi mdi-upload',
permissions=[f'auth.add_group'],
color=ButtonColorChoices.CYAN
)
)
),
get_model_item('users', 'objectpermission', _('Permissions'), actions=['add']),

View File

@ -1,5 +1,3 @@
from django import forms
from users.models import NetBoxGroup, NetBoxUser
from utilities.forms import CSVModelForm
@ -28,12 +26,7 @@ class UserImportForm(CSVModelForm):
)
def save(self, *args, **kwargs):
edited = getattr(self, 'instance', None)
instance = super().save(*args, **kwargs)
# Set the hashed password
self.instance.set_password(self.cleaned_data.get('password'))
# On edit, check if we have to save the password
if edited and self.cleaned_data.get("password"):
instance.set_password(self.cleaned_data.get("password"))
instance.save()
return instance
return super().save(*args, **kwargs)