NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-08-05 15:18:18 -06:00
Code Issues Actions 14 Packages Projects Releases Wiki Activity

17558 raise validation error if removing choice from choiceset that is currently used

Browse Source
This commit is contained in:
Arthur Hanson 2024-09-24 11:28:40 -07:00
parent b59ae0fd93
commit 52b8bd5523
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
netbox/extras/models/customfields.py
View File

@ -829,10 +829,11 @@ class CustomFieldChoiceSet(CloningMixin, ExportTemplatesMixin, ChangeLoggedModel
if self.extra_choices:
new_choices = [obj[1] for obj in self.extra_choices]
diff_choices = list(set(original_choices) - set(new_choices))
if diff_choices:
# CustomFields using this ChoiceSet
# only care about what fields are being deleted.
if diff_choices := list(set(original_choices) - set(new_choices)):
# Get all CustomFields using this ChoiceSet
for custom_field in self.choices_for.all():
# Then the models using those custom fields
for object_type in custom_field.object_types.all():
# unfortunately querying the whole array of diff_choices doesn't work
for choice in diff_choices: