NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-08 13:00:08 -06:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Address PR feedback

Browse Source
This commit is contained in:
Jason Novinger
2025-12-15 14:57:52 -06:00
parent e81e192d2e
commit 4cf0a1045c
3 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
netbox/dcim/tests/test_views.py
View File

@@ -2340,8 +2340,7 @@ class DeviceTestCase(ViewTestCases.PrimaryObjectViewTestCase):
url = reverse('dcim:device_inventory', kwargs={'pk': device.pk}) url = reverse('dcim:device_inventory', kwargs={'pk': device.pk})
self.assertHttpStatus(self.client.get(url), 200) self.assertHttpStatus(self.client.get(url), 200)
@tag('regression') # #20929 def test_device_renderconfig(self):
def test_device_renderconfig_permission(self):
configtemplate = ConfigTemplate.objects.create( configtemplate = ConfigTemplate.objects.create(
name='Test Config Template', name='Test Config Template',
template_code='Config for device {{ device.name }}' template_code='Config for device {{ device.name }}'

6
netbox/utilities/testing/base.py
View File

@@ -73,11 +73,9 @@ class TestCase(_TestCase):
""" """
for name in names: for name in names:
object_type, action = resolve_permission_type(name) object_type, action = resolve_permission_type(name)
obj_perms = ObjectPermission.objects.filter( ObjectPermission.objects.filter(
actions__contains=[action], object_types=object_type, users=self.user actions__contains=[action], object_types=object_type, users=self.user
) ).delete()
for obj_perm in obj_perms:
obj_perm.users.remove(self.user)
# #
# Custom assertions # Custom assertions

5
netbox/virtualization/tests/test_views.py
View File

@@ -1,5 +1,5 @@
from django.contrib.contenttypes.models import ContentType from django.contrib.contenttypes.models import ContentType
from django.test import override_settings, tag from django.test import override_settings
from django.urls import reverse from django.urls import reverse
from dcim.choices import InterfaceModeChoices from dcim.choices import InterfaceModeChoices
@@ -327,8 +327,7 @@ class VirtualMachineTestCase(ViewTestCases.PrimaryObjectViewTestCase):
url = reverse('virtualization:virtualmachine_interfaces', kwargs={'pk': virtualmachine.pk}) url = reverse('virtualization:virtualmachine_interfaces', kwargs={'pk': virtualmachine.pk})
self.assertHttpStatus(self.client.get(url), 200) self.assertHttpStatus(self.client.get(url), 200)
@tag('regression') # #20929 def test_virtualmachine_renderconfig(self):
def test_virtualmachine_renderconfig_permission(self):
configtemplate = ConfigTemplate.objects.create( configtemplate = ConfigTemplate.objects.create(
name='Test Config Template', name='Test Config Template',
template_code='Config for VM {{ virtualmachine.name }}' template_code='Config for VM {{ virtualmachine.name }}'