From 489b0841ab7478679e943512ad24f9ab5f2508df Mon Sep 17 00:00:00 2001 From: Jeremy Sanders <23668453+jeremypng@users.noreply.github.com> Date: Wed, 12 Feb 2025 00:24:02 +0000 Subject: [PATCH] cleanup enums, enable strawberry-django optimizer, extra line --- netbox/dcim/graphql/enums.py | 9 --------- netbox/extras/graphql/enums.py | 2 -- netbox/ipam/graphql/enums.py | 9 --------- netbox/netbox/graphql/schema.py | 3 +-- netbox/netbox/settings.py | 1 - netbox/vpn/graphql/enums.py | 2 -- netbox/wireless/graphql/enums.py | 2 -- 7 files changed, 1 insertion(+), 27 deletions(-) diff --git a/netbox/dcim/graphql/enums.py b/netbox/dcim/graphql/enums.py index 2e99ab5e9..0b3441d52 100644 --- a/netbox/dcim/graphql/enums.py +++ b/netbox/dcim/graphql/enums.py @@ -131,8 +131,6 @@ class DeviceAirflowEnum(Enum): @strawberry.enum class ModuleStatusEnum(Enum): - key = 'Module.status' - STATUS_OFFLINE = 'offline' STATUS_ACTIVE = 'active' STATUS_PLANNED = 'planned' @@ -800,8 +798,6 @@ class CableEndEnum(Enum): @strawberry.enum class PowerFeedStatusEnum(Enum): - key = 'PowerFeed.status' - STATUS_OFFLINE = 'offline' STATUS_ACTIVE = 'active' STATUS_PLANNED = 'planned' @@ -810,7 +806,6 @@ class PowerFeedStatusEnum(Enum): @strawberry.enum class PowerFeedTypeEnum(Enum): - TYPE_PRIMARY = 'primary' TYPE_REDUNDANT = 'redundant' @@ -834,8 +829,6 @@ class PowerFeedPhaseEnum(Enum): # @strawberry.enum class VirtualDeviceContextStatusEnum(Enum): - key = 'VirtualDeviceContext.status' - STATUS_ACTIVE = 'active' STATUS_PLANNED = 'planned' STATUS_OFFLINE = 'offline' @@ -847,8 +840,6 @@ class VirtualDeviceContextStatusEnum(Enum): @strawberry.enum class InventoryItemStatusEnum(Enum): - key = 'InventoryItem.status' - STATUS_OFFLINE = 'offline' STATUS_ACTIVE = 'active' STATUS_PLANNED = 'planned' diff --git a/netbox/extras/graphql/enums.py b/netbox/extras/graphql/enums.py index 959314d9e..1e44e9191 100644 --- a/netbox/extras/graphql/enums.py +++ b/netbox/extras/graphql/enums.py @@ -98,8 +98,6 @@ class BookmarkOrderingEnum(Enum): @strawberry.enum class JournalEntryKindEnum(Enum): - key = 'JournalEntry.kind' - KIND_INFO = 'info' KIND_SUCCESS = 'success' KIND_WARNING = 'warning' diff --git a/netbox/ipam/graphql/enums.py b/netbox/ipam/graphql/enums.py index 3e73773cb..b81254880 100644 --- a/netbox/ipam/graphql/enums.py +++ b/netbox/ipam/graphql/enums.py @@ -28,8 +28,6 @@ class IPAddressFamilyEnum(Enum): @strawberry.enum class PrefixStatusEnum(Enum): - key = 'Prefix.status' - STATUS_CONTAINER = 'container' STATUS_ACTIVE = 'active' STATUS_RESERVED = 'reserved' @@ -43,8 +41,6 @@ class PrefixStatusEnum(Enum): @strawberry.enum class IPRangeStatusEnum(Enum): - key = 'IPRange.status' - STATUS_ACTIVE = 'active' STATUS_RESERVED = 'reserved' STATUS_DEPRECATED = 'deprecated' @@ -57,8 +53,6 @@ class IPRangeStatusEnum(Enum): @strawberry.enum class IPAddressStatusEnum(Enum): - key = 'IPAddress.status' - STATUS_ACTIVE = 'active' STATUS_RESERVED = 'reserved' STATUS_DEPRECATED = 'deprecated' @@ -107,8 +101,6 @@ class FHRPGroupAuthTypeEnum(Enum): @strawberry.enum class VLANStatusEnum(Enum): - key = 'VLAN.status' - STATUS_ACTIVE = 'active' STATUS_RESERVED = 'reserved' STATUS_DEPRECATED = 'deprecated' @@ -119,7 +111,6 @@ class VLANQinQRoleEnum(Enum): ROLE_SERVICE = 'svlan' ROLE_CUSTOMER = 'cvlan' - # # Services # diff --git a/netbox/netbox/graphql/schema.py b/netbox/netbox/graphql/schema.py index 625f7cd1b..a7609c9d2 100644 --- a/netbox/netbox/graphql/schema.py +++ b/netbox/netbox/graphql/schema.py @@ -38,8 +38,7 @@ schema = strawberry.Schema( query=Query, config=StrawberryConfig(auto_camel_case=False), extensions=[ - # DjangoOptimizerExtension(prefetch_custom_queryset=True), - DjangoOptimizerExtension(prefetch_custom_queryset=True, enable_prefetch_related_optimization=False), + DjangoOptimizerExtension(prefetch_custom_queryset=True), MaxAliasesLimiter(max_alias_count=settings.GRAPHQL_MAX_ALIASES), ] ) diff --git a/netbox/netbox/settings.py b/netbox/netbox/settings.py index 9f514684f..1b0d2b217 100644 --- a/netbox/netbox/settings.py +++ b/netbox/netbox/settings.py @@ -775,7 +775,6 @@ LOCALE_PATHS = ( STRAWBERRY_DJANGO = { "DEFAULT_PK_FIELD_NAME": "id", "TYPE_DESCRIPTION_FROM_MODEL_DOCSTRING": True, - "USE_DEPRECATED_FILTERS": False, } # diff --git a/netbox/vpn/graphql/enums.py b/netbox/vpn/graphql/enums.py index 7b66818ad..9dc6bdac4 100644 --- a/netbox/vpn/graphql/enums.py +++ b/netbox/vpn/graphql/enums.py @@ -23,8 +23,6 @@ __all__ = [ @strawberry.enum class TunnelStatusEnum(Enum): - key = 'Tunnel.status' - STATUS_PLANNED = 'planned' STATUS_ACTIVE = 'active' STATUS_DISABLED = 'disabled' diff --git a/netbox/wireless/graphql/enums.py b/netbox/wireless/graphql/enums.py index 1526b2ff3..da8368cde 100644 --- a/netbox/wireless/graphql/enums.py +++ b/netbox/wireless/graphql/enums.py @@ -18,8 +18,6 @@ class WirelessRoleEnum(Enum): @strawberry.enum class WirelessLANStatusEnum(Enum): - key = 'WirelessLAN.status' - STATUS_ACTIVE = 'active' STATUS_RESERVED = 'reserved' STATUS_DISABLED = 'disabled'