NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-28 19:36:26 -06:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Fixes #3878: Fix database migration for cable status field

Browse Source
This commit is contained in:
Jeremy Stretch 2020-01-09 16:16:24 -05:00
parent 40169c84e0
commit 434f265345
3 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/release-notes/version-2.7.md
View File

@ -238,6 +238,7 @@ PATCH) to maintain backward compatibility. This behavior will be discontinued be
## Bug Fixes (From Beta)
* [#3868](https://github.com/digitalocean/netbox/issues/3868) - Fix creation of interfaces for virtual machines
* [#3878](https://github.com/digitalocean/netbox/issues/3878) - Fix database migration for cable status field
## API Changes

8
netbox/dcim/migrations/0083_3569_cable_fields.py
View File

@ -24,8 +24,8 @@ CABLE_TYPE_CHOICES = (
)
CABLE_STATUS_CHOICES = (
(True, 'connected'),
(False, 'planned'),
('true', 'connected'),
('false', 'planned'),
)
CABLE_LENGTH_UNIT_CHOICES = (
@ -44,8 +44,8 @@ def cable_type_to_slug(apps, schema_editor):
def cable_status_to_slug(apps, schema_editor):
Cable = apps.get_model('dcim', 'Cable')
for bool, slug in CABLE_STATUS_CHOICES:
Cable.objects.filter(status=str(bool)).update(status=slug)
for bool_str, slug in CABLE_STATUS_CHOICES:
Cable.objects.filter(status=bool_str).update(status=slug)
def cable_length_unit_to_slug(apps, schema_editor):

2
netbox/dcim/tests/test_filters.py
View File

@ -2188,6 +2188,8 @@ class CableTestCase(TestCase):
self.assertEqual(self.filterset(params, self.queryset).qs.count(), 4)
def test_status(self):
params = {'status': [CableStatusChoices.STATUS_CONNECTED]}
self.assertEqual(self.filterset(params, self.queryset).qs.count(), 3)
params = {'status': [CableStatusChoices.STATUS_PLANNED]}
self.assertEqual(self.filterset(params, self.queryset).qs.count(), 3)