From 40fe303f00d42248221a59e74c59abc4bc5e1366 Mon Sep 17 00:00:00 2001
From: Andrew Gormley <andrewgormley91@gmail.com>
Date: Thu, 1 Aug 2024 01:18:33 +0100
Subject: [PATCH] fixes issues in #16850 (#16986)

* fixes issues in #16850: issue 3 and 5

* Add link text for 'clear' button on table column

* Translate aria label

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
---
 netbox/netbox/tables/columns.py      | 1 +
 netbox/templates/inc/table_htmx.html | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/netbox/netbox/tables/columns.py b/netbox/netbox/tables/columns.py
index 2f5d4ecd1..8489648f3 100644
--- a/netbox/netbox/tables/columns.py
+++ b/netbox/netbox/tables/columns.py
@@ -173,6 +173,7 @@ class ToggleColumn(tables.CheckBoxColumn):
             kwargs['attrs'] = {
                 'th': {
                     'class': 'w-1',
+                    'aria-label': _('Select all'),
                 },
                 'td': {
                     'class': 'w-1',
diff --git a/netbox/templates/inc/table_htmx.html b/netbox/templates/inc/table_htmx.html
index 446a77643..0165b1d29 100644
--- a/netbox/templates/inc/table_htmx.html
+++ b/netbox/templates/inc/table_htmx.html
@@ -1,4 +1,5 @@
 {% load django_tables2 %}
+{% load i18n %}
 <table{% if table.attrs %} {{ table.attrs.as_html }}{% endif %} hx-disinherit="hx-target hx-select" hx-swap="outerHTML">
   {% if table.show_header %}
     <thead
@@ -14,6 +15,7 @@
                   <a href="#"
                      hx-get="{{ table.htmx_url }}{% querystring table.prefixed_order_by_field='' %}"
                      class="text-danger"
+                     title="{% trans "Clear ordering" %}"
                   ><i class="mdi mdi-close"></i></a>
                 </div>
               {% endif %}