From 3f50b4f412b90b74263360860c859d25080efa15 Mon Sep 17 00:00:00 2001 From: Arthur Hanson Date: Fri, 11 Oct 2024 10:50:11 -0700 Subject: [PATCH] 17614 review changes --- netbox/dcim/models/devices.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/netbox/dcim/models/devices.py b/netbox/dcim/models/devices.py index 554c8390b..90b3e4e88 100644 --- a/netbox/dcim/models/devices.py +++ b/netbox/dcim/models/devices.py @@ -983,10 +983,10 @@ class Device( 'vc_position': _("A device assigned to a virtual chassis must have its position defined.") }) - if hasattr(self, 'vc_master_for') and self.vc_master_for and self.vc_master_for != self.virtual_chassis: + if vc_master_for := getattr(self, 'vc_master_for', None) != self.virtual_chassis: raise ValidationError({ - 'virtual_chassis': _("Cannot change to a different virtual chassis when assigned as a master. Remove it as the master of {master} first.").format( - master=self.vc_master_for + 'virtual_chassis': _('Device cannot be removed from virtual chassis {virtual_chassis} because it is currently designated as its master.').format( + virtual_chassis=self.vc_master_for ) })