From 3cc1f3028761f2269d8517e8309a60ca18eb568a Mon Sep 17 00:00:00 2001 From: Aditya Sharma <100428589+adionit7@users.noreply.github.com> Date: Tue, 20 Jan 2026 22:20:31 +0530 Subject: [PATCH] Fixes #21213: Make Tag weight field required in forms (#21218) The weight field was explicitly declared with required=False in TagForm and TagImportForm, allowing empty submissions that would crash with a database IntegrityError since the column is NOT NULL. By removing the explicit field override, Django now auto-generates the form field from the model, which has default=1000 and is required. Co-authored-by: adionit7 --- netbox/extras/forms/bulk_import.py | 4 ---- netbox/extras/forms/model_forms.py | 4 ---- 2 files changed, 8 deletions(-) diff --git a/netbox/extras/forms/bulk_import.py b/netbox/extras/forms/bulk_import.py index afe0de5d1..d57b2f27c 100644 --- a/netbox/extras/forms/bulk_import.py +++ b/netbox/extras/forms/bulk_import.py @@ -271,10 +271,6 @@ class EventRuleImportForm(OwnerCSVMixin, NetBoxModelImportForm): class TagImportForm(OwnerCSVMixin, CSVModelForm): slug = SlugField() - weight = forms.IntegerField( - label=_('Weight'), - required=False - ) object_types = CSVMultipleContentTypeField( label=_('Object types'), queryset=ObjectType.objects.with_feature('tags'), diff --git a/netbox/extras/forms/model_forms.py b/netbox/extras/forms/model_forms.py index 7bf06ca24..68151c80b 100644 --- a/netbox/extras/forms/model_forms.py +++ b/netbox/extras/forms/model_forms.py @@ -571,10 +571,6 @@ class TagForm(ChangelogMessageMixin, OwnerMixin, forms.ModelForm): queryset=ObjectType.objects.with_feature('tags'), required=False ) - weight = forms.IntegerField( - label=_('Weight'), - required=False - ) fieldsets = ( FieldSet('name', 'slug', 'color', 'weight', 'description', 'object_types', name=_('Tag')),