NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-08-24 08:25:17 -06:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

11508 review changes - add error checking

Browse Source
This commit is contained in:
Arthur 2023-08-17 08:32:52 -07:00
parent 816eb75d78
commit 3cb5ba7fa9
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
netbox/netbox/authentication.py
View File

@ -443,12 +443,16 @@ def azuread_map_groups(response, user, backend, *args, **kwargs):
# Set groups and permissions based on returned group list # Set groups and permissions based on returned group list
is_superuser = False is_superuser = False
is_staff = False is_staff = False
values = response.json().get('value', []) try:
values = response.json().get('value', [])
except Exception as e:
logger.error(f"Azure AD group mapping error getting groups json response for user {user} from Microsoft Graph API: {e}")
raise e
user.groups.through.objects.filter(user=user).delete() user.groups.through.objects.filter(user=user).delete()
for value in values: for value in values:
# AD response contains both directories and groups - we only want groups # AD response contains both directories and groups - we only want groups
if value.get('@odata.type') == '#microsoft.graph.group': if value.get('@odata.type', None) == '#microsoft.graph.group':
group_id = value.get('id', None) group_id = value.get('id', None)
if group_id in flags_by_group['is_superuser']: if group_id in flags_by_group['is_superuser']: