NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-17 04:32:51 -06:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

Fixes #13849: Fix label resolution during serialization for removed field choices (#13867)

Browse Source 
* Fixes #13849: Fix label resolution during serialization for removed field choices

* Cleanup
This commit is contained in:
Jeremy Stretch 2023-09-26 12:06:47 -04:00 committed by GitHub
parent 099aff5ebe
commit 3cb41bbe3a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
netbox/netbox/api/fields.py
View File

@ -46,11 +46,12 @@ class ChoiceField(serializers.Field):
return super().validate_empty_values(data) return super().validate_empty_values(data)
def to_representation(self, obj): def to_representation(self, obj):
if obj == '': if obj != '':
return None # Use an empty string in place of the choice label if it cannot be resolved (i.e. because a previously
# configured choice has been removed from FIELD_CHOICES).
return { return {
'value': obj, 'value': obj,
'label': self._choices[obj], 'label': self._choices.get(obj, ''),
} }
def to_internal_value(self, data): def to_internal_value(self, data):