From 3c2ddf1f69d9ee2e2a48a9062dda434640e91ba3 Mon Sep 17 00:00:00 2001 From: Jeremy Stretch Date: Tue, 15 Dec 2020 16:17:52 -0500 Subject: [PATCH] Fixes #5444: Don't force overwriting of mgmt_only when bulk editing interfaces --- docs/release-notes/version-2.10.md | 1 + netbox/dcim/forms.py | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/release-notes/version-2.10.md b/docs/release-notes/version-2.10.md index 9651cf6c4..42da90f57 100644 --- a/docs/release-notes/version-2.10.md +++ b/docs/release-notes/version-2.10.md @@ -4,6 +4,7 @@ ### Bug Fixes +* [#5444](https://github.com/netbox-community/netbox/issues/5444) - Don't force overwriting of `mgmt_only` when bulk editing interfaces * [#5450](https://github.com/netbox-community/netbox/issues/5450) - API serializer foreign count fields do not have a default value * [#5453](https://github.com/netbox-community/netbox/issues/5453) - Correct change log representation when creating a cable * [#5458](https://github.com/netbox-community/netbox/issues/5458) - Creating a component template throws an exception diff --git a/netbox/dcim/forms.py b/netbox/dcim/forms.py index ca7602bf2..33872539b 100644 --- a/netbox/dcim/forms.py +++ b/netbox/dcim/forms.py @@ -2839,7 +2839,7 @@ class InterfaceBulkCreateForm( class InterfaceBulkEditForm( form_from_model(Interface, [ - 'label', 'type', 'enabled', 'lag', 'mac_address', 'mtu', 'mgmt_only', 'description', 'mode' + 'label', 'type', 'enabled', 'lag', 'mac_address', 'mtu', 'description', 'mode' ]), BootstrapMixin, AddRemoveTagsForm, @@ -2855,6 +2855,11 @@ class InterfaceBulkEditForm( disabled=True, widget=forms.HiddenInput() ) + mgmt_only = forms.NullBooleanField( + required=False, + widget=BulkEditNullBooleanSelect, + label='Management only' + ) untagged_vlan = DynamicModelChoiceField( queryset=VLAN.objects.all(), required=False,